Repository navigation
docs: check upstream Kratos before implementing fork changes - #20
Merged
gn-kim-k merged 2 commits intoOct 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents working on this fork should check whether Ory Kratos already has a suitable change before implementing their own. Add root
AGENTS.mdas the canonical guidance and a relativeCLAUDE.md -> AGENTS.mdsymlink so both entry points discover it.The workflow prefers an attributed cherry-pick or minimal port, requires checking prerequisites and Goodnotes compatibility, and allows normal local implementation when no upstream change applies. PRs should record the upstream search, its outcome, and validation against this fork. Also clarify that fork PRs target
goodnotes, despite the inherited upstream contribution instructions referring tomaster.Upstream check
Inspected the root of
ory/kratosatmastercommitb86338da04a040247a07f46100a86dcfb3875909; neitherAGENTS.mdnorCLAUDE.mdexists there. This change defines Goodnotes fork maintenance policy rather than changing upstream runtime behavior.Validation
CLAUDE.mdresolves toAGENTS.md, reads identical contents, and is tracked by Git as a symlink (mode120000).git diff --cached --checkpassed.This is separate from the Microsoft raw-claims fix in #19.