Repository navigation
fix(harness): correct the text layer for DreamCoder and non-Claude models - #287
Merged
Merged
Conversation
…dels Part of #270. Memory writes in the server's memory directory no longer ask for approval; the transcript keeps all attachments and Stop ends the CLI only when the turn did not stop; the skill list is derived from the history; resuming adds no synthetic messages; internal-build-only text is removed; non-Claude models get mid-turn text as separate blocks; the environment, help, Read, update-config, worktree, plan mode, AskUserQuestion, file-changed and compaction texts describe DreamCoder; /goal continues, caps at 10 continuations and stops when blocked on the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #270. Sub-issues #271–#280 are not included.
What changed
Context and memory
CLAUDE_COWORK_MEMORY_PATH_OVERRIDE), so saving a memory no longer asks for approval, also in bypass mode.skill_listingattachments now carryskillNames) instead of a per-process set. After compaction the full list is sent again in the post-compact attachments; when skill folders change only new skills are listed ("These skills are now also available…"); after a CLI restart nothing is resent.sentSkillNames,resetSentSkillNamesandsuppressNextSkillListingare removed.MEMORY.mdmoves out from under the instruction preface with its own note.MEMORY.mdindex.CLI restarts
isLoggableMessagedrops only progress messages).stopRequestedis cleared by the CLI'sresult); otherwise the process phase goes back torunning.CLAUDE_CODE_RESUME_INTERRUPTED_TURN) enqueues the continuation itself.Text for the model in use
USER_TYPE === 'ant'text branches in the system prompt and tool descriptions are deleted (ant-only behavior code is untouched).isClaudeModelName, moved tosrc/utils/model/claudeModelName.tsand shared with the server); Claude models keep the fold. Only the request to the model changes./fastlines are removed for every model. When the app starts the CLI (DREAMCODER_DESKTOP_HOST=1), one line says it runs in the DreamCoder app.# Systemand Tone no longer promise a monospace font or clickable links;/helpand feedback point to DreamCoder.update-config: DreamCoder wording, no Config tool./statuslineremoved.Behavior the text got wrong
planModeV2.ts.answers,annotationsandmetadata, and dropspreviewunless the client renders previews (the terminal UI); the tool's own schema still accepts the desktop app's answer./goalnow actually continues. The evaluator's "not met" result carried both a blocking error and a stop request;executeHooksyields them separately, so the stop request arrived without the goal marker and ended the turn at the first check. A /goal hook's unmet result now carries only the blocking error (unmetPromptHookResult), and the after-the-factshouldLetGoalPromptHookContinueis removed./goal: the continuation message names the goal, what the evaluator says is missing and the count; at most 10 consecutive continuations per user message (counted in the query loop state, so compaction does not reset it), the 10th asks for a report./goal: the evaluator can answer that the agent is blocked on the user (blocked: true, added only to the prompt hook's own response schema). The turn then ends without a continuation and the goal stays active; other prompt hooks ignore the field.compactRequestMessages).Provider check for separate user messages after tool messages
Request: system → user → assistant (tool_calls) → tool → user (a
<system-reminder>with a cross-session message), one function tool. 11 requests through OpenRouter:The official GLM, DeepSeek and Kimi APIs were not tested.
How it was tested
bun test --randomize --seed=1on the 27 changed test files: 185 pass.src/query/goalContinuationLoop.test.tsdrives the real query loop throughQueryEngine(model calls, Stop hook execution and auto-compaction replaced): continuations are numbered 1 to 10 across a compaction and the turn ends after the 10th; a blocked answer ends the turn and keeps the goal.bun test: the same 11 failures as onmain(environment-dependent: ripgrep, inherited Claude Code customizations, agent cache, slash-command listing), nothing new.desktop/is not changed.Not in this PR