Repository navigation
Conversation
Tell the session-title model this is naming, not conversation: never answer or fulfill the message, and write the title in the user's primary language. Closes GoDiao#277
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds two instructions to the server session-title system prompt in
src/server/services/titleService.ts(T-SYS-09 / #277):Also adds a regression test that captures the upstream
systemfield and asserts those phrases are present, and a CHANGELOG entry under## [Unreleased]→ Fixed.Why
Without those lines, a model may answer the first user message instead of naming the session (long answers are discarded and the placeholder title stays), or produce an English title for a non-English conversation.
How it was tested
mainprompt text and passes with this change.bun run prepare:ripgrepbun test ./src/server/__tests__/title-service.test.ts: 16 pass, 0 failbun test --randomize --seed=1 ./src/server/__tests__/title-service.test.ts: 16 pass, 0 failcd desktop && bun run lint: passcd desktop && bun run test -- --run: 3119 pass, 4 skipped, 0 failbun test: 2889 pass, 2 skip, 21 fail. All 21 failures are 5s timeouts in SessionService / Sessions API / ArtifactService worktree and artifact tests. None are intitle-service. A sample of one of those timed-out tests (should move repository metadata into the CLI worktree transcript) passes when run alone (101 ms). These look like full-suite resource contention in this Linux environment, not regressions from this prompt-text change.Scope
Does not change #279, #274, or other #270 sub-issues.
Closes #277