Skip to content

Clarify Crypto buffer access lifetime #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
athoelke wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarify Crypto buffer access lifetime #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/crypto/appendix/history.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Changes in the draft GlobalPlatform publication revision
Clarifications and fixes
~~~~~~~~~~~~~~~~~~~~~~~~

* Clarified that an implementation accesses memory referenced by a pointer or buffer parameter only during the function call, and consumes input buffers before returning.
* Corrected the WPA3-SAE operation example code: the send-confirm counter input step is `PSA_PAKE_STEP_CONFIRM_COUNT`, and the shared key is extracted from the ``wpa3_sae`` operation.
* Corrected the SPAKE2+ operation example code: the Prover input step for the Verifier confirmation value is `PSA_PAKE_STEP_CONFIRM`.

Expand Down
5 changes: 5 additions & 0 deletions doc/crypto/overview/conventions.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,11 @@ readable, and the implementation must be able to write to a non-buffer output
parameter and read back the same value, as explained in
:secref:`stability-of-parameters`.

The implementation accesses memory referenced by a pointer or buffer parameter
only during the function call. In particular, it must consume input buffers
before returning and must not access the caller's memory after the function
returns.

Input buffer sizes
^^^^^^^^^^^^^^^^^^

Expand Down