Skip to content

feat: analyze all dataset categories and actual PR diffs - #95

Merged
Seungpyo1007 merged 1 commit into
mainfrom
feat/bot-full-coverage
Sep 26, 2026
Merged

Seungpyo1007 merged 1 commit into
mainfrom
feat/bot-full-coverage

Conversation

@Seungpyo1007

@Seungpyo1007 Seungpyo1007 commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

TechEngineBot now analyzes all 12 seed categories instead of eight, applies structural integrity checks to every category, and compares changed records against the actual PR base. Develop PRs count only their own changes; develop-to-main release PRs include the release diff. PRs changing site/public/v1 also parse every changed JSON and compare each collection's manifest/index counts and index result length with seed record counts.

Laptop, monitor, software and website receive required-field, slug/file and source assessment; absent domain consistency rules earn zero credit and cannot produce green. Both validation comments and verification comments disclose category coverage, current record count and the PR base branch/SHA. Missing dispatch base fields are resolved from the PR API for backward compatibility.

The verifier recomputes reports if its local scores cache is absent, and the scheduled network workflow no longer writes that cache before committing data changes.

Validation: all 441 tests pass with TECHAPI_DATA_DIR=C:/Users/29/Desktop/TechAPI/data and python -m pytest tests -q --basetemp=C:/tmp/techengine-full-coverage-final; python -m mypy app and python -m ruff check app tests pass. All 14 new coverage tests also pass independently. The full integrity scan reads 191,797 records across 12 categories and reports 18 preexisting CPU anomalies, with none in the newly covered categories. Workflow YAML and embedded Python syntax were checked. The change is 480 added/deleted lines, within one focused PR.

TechAPI-side changes required

  • .github/workflows/request-engine-pr-validation.yml: add base_ref: context.payload.pull_request.base.ref and base_sha: context.payload.pull_request.base.sha to the techapi-pr-validate dispatch client_payload (use equivalent github.event.pull_request.base.ref/sha expressions if building JSON in shell).
  • .github/workflows/verify-report.yml: add the same base_ref and base_sha fields to the techapi-verify dispatch payload. Add site/public/v1/** to its pull-request paths if dump-only PRs should also receive the Tier 0 report; the existing validation relay already checks dump changes.
  • .github/workflows/verify-command.yml: when fetching the target PR for /verify, add base_ref: pr.base.ref and base_sha: pr.base.sha to the dispatch payload.
  • TechAPI .gitignore: add /data/_verify/state/; run git rm --cached data/_verify/state/scores.jsonl to untrack the existing 43.5 MB generated cache while keeping local copies. Untrack other cache files in that directory if tracked; retain the promotion ledger outside state/.

No TechAPI checkout or submodule pointer is changed by this PR. The structural gate may now reveal preexisting anomalies in previously omitted categories; its baseline comparison blocks only newly introduced hard anomalies. Full-domain scoring rules for the four new categories remain future work, explicitly disclosed in reports.

Refs GetTechAPI/TechAPI#1

@Seungpyo1007 Seungpyo1007 added enhancement New feature or request ci Continuous integration changes labels Sep 26, 2026
@Seungpyo1007 Seungpyo1007 self-assigned this Sep 26, 2026
@Seungpyo1007
Seungpyo1007 merged commit a7a858c into main Sep 26, 2026
1 check passed
@Seungpyo1007
Seungpyo1007 deleted the feat/bot-full-coverage branch September 26, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant