Skip to content

Allow opt-in Commons backfill for missing image URL keys - #88

Merged
Seungpyo1007 merged 1 commit into
mainfrom
feat/wikipedia-image-missing-key-backfill
Sep 25, 2026
Merged

Seungpyo1007 merged 1 commit into
mainfrom
feat/wikipedia-image-missing-key-backfill

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

Summary

  • Add --include-missing-key to include smartphone records without an image_url key; the default still requires an explicit null.
  • Insert image fields into missing-key JSON records without changing other content or line endings.
  • Cover opt-in eligibility and surgical insertion with offline tests.

Verification

  • python -m pytest tests/verify/test_wikipedia_image_backfill.py --basetemp C:/Users/29/AppData/Local/Temp/techengine-wiki-image-pytest -q
  • python -m mypy app
  • python -m ruff check app tests
  • python -m ruff format --check app/verify/wikipedia_image_backfill.py tests/verify/test_wikipedia_image_backfill.py

@Seungpyo1007
Seungpyo1007 merged commit 5e8a17c into main Sep 25, 2026
1 check passed
@Seungpyo1007
Seungpyo1007 deleted the feat/wikipedia-image-missing-key-backfill branch September 25, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant