Classify Wikidata brand references as Tier 2 sources - #86
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wikidata entity pages were unclassified (host tier 0), even though Wikidata is a secondary structured knowledge base. Add
wikidata.orgto Tier 2 and cover its host classification and effect on a fully populated brand record. This changes source classification only; the completeness, consistency, provenance, score threshold, and live-source promotion gates stay intact.Wikidata describes itself as a collaborative secondary knowledge base: https://www.wikidata.org/wiki/Wikidata:Introduction/simple
Near-miss analysis
Regenerated 83,847 unverified Tier-0 scores using
TECHAPI_DATA_DIR=C:\Users\29\Desktop\TechAPI\dataandpython -m app.verify score --unverified-only. The requested pool (yellow,best_host_tier <= 2,65 <= score < 75) contains 2,757 records, 2,698 without flags. The<= 2filter includes tier 0, which means unclassified hosts.The dominant 1,963-smartphone joint cohort scores 12.5 + 35 + 18 + 7 = 72.5. All 1,963 lack cameras, wired charging power, and OS version; 1,962 also lack storage options. The records have OS family in
os, but that does not supply the absent version, and the missing camera/storage/charging data are real gaps in these records. I left those deductions unchanged. The 101-brand cohort has both richness fields and full consistency but gets only 3 host points because its cited hosts are unclassified. Sixty-eight of those records cite Wikidata item pages. Other low completeness cohorts contain actual missing normalized fields (for example SoC CPU configuration and CPU socket, TDP, or L3 cache), so they were not changed.Measured effect
Re-scoring brand records against the pre-change scores cache yields 68 requested near-miss records changing yellow → green (70.0 → 85.0). Thirty more brands outside that pool change yellow → green (73.0 → 85.0) because they cite Wikidata alongside a Tier-3 host. Total band changes: 98 yellow → green; no other brand band changes. These are offline green candidates; promotion still requires the existing live-source or cross-reference decision.
Checks
python -m pytest tests/verify --basetemp C:\Users\29\AppData\Local\Temp\techengine-verify-all-pytest— 145 passedpython -m mypy app— passedpython -m ruff check app tests— passedgit diff --check— passedNo TechAPI data JSON was edited. The pre-existing local
TechAPIsubmodule change was left untouched.