fix(verify): use source chipset year for late SoC placeholders - #81
Merged
Merged
Conversation
Member
Author
|
Refs GetTechAPI/TechAPI#1 (verify-layer near-miss investigation: soc_not_after_device false placeholder-date signal, 472-record sample -> 413 newly green). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
The remaining
soc_not_after_devicenear misses are dominated by SoC-side placeholder dates, not a need for a wider year tolerance. In the 2026-09-23 TechAPIscores.jsonlsnapshot, 472 yellow records with score 65–74 and a T1/T2 host carry the flag; 471 reference aYYYY-01-01SoC date. The SoCraw_chipsetfield contains a structured, earlier chipset year for 417 of them (for example, Snapdragon 680: normalized 2025, raw 2021; Snapdragon 210: normalized 2018, raw 2014). Their device dates agree with that source year under the existing two-year placeholder tolerance.Change
When building the SoC release-date lookup, use the year embedded in the SoC's
raw_chipsettext only if it follows the import'sname, YYYY, ...format and is earlier than a normalized January 1 placeholder. Keep exact dates, absent or unstructured raw text, and the existing two-year tolerance unchanged. This preserves flags for a 2015 device referencing Snapdragon 8s Gen 3 (2024) and a 2023 device referencing a day-precise 2024 Dimensity release.Estimated impact
Replaying the current scorer against those 472 records resolves the flag for 417. Of those, 413 move from yellow to green; four already score green against current files but remain yellow in the stale scores cache. The other 55 remain flagged, primarily where
raw_chipsethas no year, and need data-side review. No TechAPI files were modified.Verification
python -m pytest tests/verify/test_common_soc_dates.py tests/verify/test_signals.py -q --confcutdir=tests/verify— 22 passed.python -m ruff check app/verify/common.py tests/verify/test_common_soc_dates.py— passed.python -m mypy app/verify/common.py— passed.