Skip to content

Fix dead brand source URLs and logo references - #255

Merged
Seungpyo1007 merged 3 commits into
developfrom
fix/dead-source-urls
Sep 25, 2026
Merged

Seungpyo1007 merged 3 commits into
developfrom
fix/dead-source-urls

Conversation

@Seungpyo1007

@Seungpyo1007 Seungpyo1007 commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Changes

Replaced confirmed dead company URLs and cleared six Commons logo fields whose files are missing on both Commons and the upload host. Kaggle dataset URLs and the ROG Phone 10 URL were left untouched.

Record Field Old New
Colorful source_urls https://en.wikipedia.org/wiki/Colorful_(company) https://zh.wikipedia.org/wiki/%E4%B8%83%E5%BD%A9%E8%99%B9
Thomson source_urls https://en.wikipedia.org/wiki/Thomson_(brand) https://fr.wikipedia.org/wiki/Thomson_(marque)
Elo Touch Solutions source_urls https://en.wikipedia.org/wiki/Elo_TouchSystems https://www.elotouch.com/
Kensington source_urls https://en.wikipedia.org/wiki/Kensington_(brand) https://en.wikipedia.org/wiki/Kensington_Computer_Products_Group
Sceptre source_urls https://en.wikipedia.org/wiki/Sceptre_Incorporated https://zh.wikipedia.org/wiki/%E8%B5%9B%E6%99%AE%E7%89%B9
KOORUI source_urls https://en.wikipedia.org/wiki/HKC_(company) https://www.hkcglobal.net/
NXP Semiconductors website https://www.nxp.com https://en.wikipedia.org/wiki/NXP_Semiconductors
NXP Semiconductors source_urls https://www.nxp.com https://en.wikipedia.org/wiki/NXP_Semiconductors
Emporia Telecom logo_url https://commons.wikimedia.org/wiki/Special:FilePath/Emporia.jpg null
AYANEO logo_url https://commons.wikimedia.org/wiki/Special:FilePath/Ayaneo_Logo.png null
LeEco logo_url https://commons.wikimedia.org/wiki/Special:FilePath/LeEco_logo.png null
Smartisan logo_url https://commons.wikimedia.org/wiki/Special:FilePath/Smartisan_logo.png null
T-Head Semiconductor logo_url https://commons.wikimedia.org/wiki/Special:FilePath/T-Head_Logo.png null
Bullitt Group logo_url https://commons.wikimedia.org/wiki/Special:FilePath/Bullitt-Group-Logo.png null

Validation

PYTHONIOENCODING=utf-8 python -m app.validate passed.

Refs #1

@Seungpyo1007 Seungpyo1007 added enhancement New feature or request data Dataset changes labels Sep 25, 2026
@github-actions github-actions Bot added the bug Something isn't working label Sep 25, 2026
@Seungpyo1007 Seungpyo1007 removed the bug Something isn't working label Sep 25, 2026
@TechEngineBot

Copy link
Copy Markdown
Member

🔎 Data verification — Tier 0 (offline existence/trust)

Scored by app.verify; posted by TechEngineBot. Informational only — the structural gate (app.validate) is separate and authoritative for merge.

Changed records in this PR

13 record(s) scored.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 7
    "Yellow" : 6
    "Red" : 0
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
brand 🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨🟨 13 7 6 0 53.8%
All 🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨🟨 13 7 6 0 53.8%

Full-dataset baseline

105773 record(s) scored.

%%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
    title Verification bands — all records
    "Green" : 23540
    "Yellow" : 81137
    "Red" : 1096
Loading
Category Distribution Total 🟢 🟡 🔴 🟢 %
brand 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 207 122 85 0 58.9%
soc 🟩🟨🟨🟨🟨🟨🟥🟥🟥🟥🟥🟥 2077 231 824 1022 11.1%
smartphone 🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 93396 17909 75419 68 19.2%
tablet 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 3455 284 3170 1 8.2%
watch 🟩🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟥 433 39 390 4 9.0%
pda 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 140 83 57 0 59.3%
gpu 🟩🟩🟩🟩🟩🟩🟩🟨🟨🟨🟨🟨 2030 1211 819 0 59.7%
cpu 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟨🟥 4035 3661 373 1 90.7%
All 🟩🟩🟩🟨🟨🟨🟨🟨🟨🟨🟨🟥 105773 23540 81137 1096 22.3%

Hard violations (forced red):

Count Check
1 !boost_ge_base

green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to verified runs in the scheduled verify-network workflow.

@Seungpyo1007
Seungpyo1007 merged commit 9a569d8 into develop Sep 25, 2026
5 checks passed
@Seungpyo1007
Seungpyo1007 deleted the fix/dead-source-urls branch September 25, 2026 04:45
@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine change review: PASS

Check Result
python -m app.validate PASS
New hard integrity anomalies vs PR base PASS

Changed data

Category Added Modified Deleted Added verified Added unverified Added Kaggle-sourced
brand 0 13 0 0 0 0
soc 0 0 0 0 0 0
smartphone 0 0 0 0 0 0
tablet 0 0 0 0 0 0
watch 0 0 0 0 0 0
pda 0 0 0 0 0 0
gpu 0 0 0 0 0 0
cpu 0 0 0 0 0 0

Changed record examples

brand modified

  • brand/at/emporia.json - Emporia Telecom
  • brand/cn/ayaneo.json - AYANEO
  • brand/cn/colorful.json - Colorful
  • brand/cn/koorui.json - KOORUI
  • brand/cn/leeco.json - LeEco
  • brand/cn/smartisan.json - Smartisan
  • brand/cn/t-head.json - T-Head Semiconductor
  • brand/fr/thomson.json - Thomson
  • brand/gb/bullitt.json - Bullitt Group
  • brand/nl/nxp.json - NXP Semiconductors
  • brand/us/elo.json - Elo Touch Solutions
  • brand/us/kensington.json - Kensington
  • brand/us/sceptre.json - Sceptre

Heuristic review

  • Heuristic warnings: none found.

@TechEngineBot

Copy link
Copy Markdown
Member

TechEngine validation stats: PASS

Data summary

Category Total Verified Unverified Missing verified Tracked Verified % of tracked
brand 207 122 85 0 207 58.9%
soc 2077 193 1884 0 2077 9.3%
smartphone 93396 17501 75895 0 93396 18.7%
tablet 3455 273 3182 0 3455 7.9%
watch 433 39 394 0 433 9.0%
pda 140 74 66 0 140 52.9%
gpu 2030 1028 1002 0 2030 50.6%
cpu 4035 2869 1166 0 4035 71.1%
all 105773 22099 83674 0 105773 20.9%

Warning

Tracked verified coverage is below 50% for tablet 7.9% (273/3455), watch 9.0% (39/433), soc 9.3% (193/2077), smartphone 18.7% (17501/93396), all 20.9% (22099/105773).
Tracked coverage excludes records missing the verified field; see the Missing verified column for those records.
This does not fail validation. Keep imported records verified: false until manual audit, but treat this as follow-up verification work before relying on the affected categories as curated data.

Validation notes

  • The integrity gate blocks only hard anomalies introduced by this PR relative to its merge base.
  • Full advisory outlier listings are suppressed on successful runs because they are dataset-wide and mostly stable between PRs.
  • Failure runs still include a detailed log excerpt for debugging.

Key output:

## app.validate
## integrity_check.py (PR head compared with PR base)
loaded CPU=4035 GPU=2030
Integrity section Flagged lines
structural 18
CPU name/tier consistency (desktop mainstream only) 0
CPU single>multi (cinebench/geekbench — should be multi>=single) 0
CPU era-vs-score outliers 8
CPU cross-source ratio outliers (possible wrong-variant) 155
GPU cross-source ratio outliers + sanity 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data Dataset changes enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants