fix(data): null out 367 broken placeholder image_url values - #244
Merged
Merged
Conversation
Member
🔎 Data verification — Tier 0 (offline existence/trust)Scored by Changed records in this PR406 record(s) scored. %%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
title Verification bands — all records
"Green" : 404
"Yellow" : 2
"Red" : 0
Full-dataset baseline105800 record(s) scored. %%{init: {"theme":"base","themeVariables":{"pie1":"#3fb950","pie2":"#d29922","pie3":"#f85149","pieStrokeWidth":"0px","pieOpacity":"1"}}}%%
pie showData
title Verification bands — all records
"Green" : 23435
"Yellow" : 81244
"Red" : 1121
Hard violations (forced red):
green = authoritative source + complete + consistent · yellow = plausible, needs confirmation · red = sparse/weak source or a hard contradiction. Promotion to |
Member
TechEngine change review: PASS
Changed data
Changed record examplessmartphone modified
Heuristic review
|
Member
TechEngine validation stats: PASS
Data summary
Warning Tracked verified coverage is below 50% for tablet 7.2% (248/3455), soc 8.7% (184/2104), watch 9.0% (39/433), brand 11.6% (24/207), smartphone 18.7% (17495/93396), all 20.7% (21953/105800). Validation notes
Key output:
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TechPicks (reference-consumer app) reported all
image_url404s on its canonical device set. Root cause: 367 hand-curated flagship smartphone records (366 of themverified: true) hadimage_urlliterally set tohttps://cdn.jsdelivr.net/gh/GetTechAPI/images/smartphones/{slug}.webp— copied from SPEC.md's old (also-wrong) response example. That repo (GetTechAPI/images) has never existed; every one of those 367 URLs 404s. Older bulk-imported records are unaffected (they hotlink real hosts like gsmarena.com/aitoolbuzz.com and work fine).image_urlon the 367 affected records (surgical single-line diff, no reformatting) rather than leaving an actively-wrong value in place.source_urls— real image backfill from Wikipedia infoboxes is a viable follow-up, tracked separately (not in this PR).model_3d/bodyschema fields added in TechEngine PR test: post-migration /verify e2e (throwaway) #83 for the first time (schema-wide, touches every smartphone dump page) plus catch-up from PR feat(data): Wikipedia URL backfill for smartphones/tablets + dump refresh #240 which had gone unmerged since yesterday.Closes #1
Test plan
python -m app.validatepassed