Repository navigation
fix: add docs snippets; fix open api issues - #1913
Merged
Merged
Conversation
szuperaz
commented
Oct 15, 2026
| custom: {}, | ||
| // The API reads the AI indicator fields from `custom` and puts them on the event it | ||
| // delivers. They aren't app custom data, hence the assertion. | ||
| custom: { |
Contributor
Author
There was a problem hiding this comment.
This one threw me off at first, but I verified that, for ai_indicator.update events, the message_id and ai_state fields need to be wrapped in custom, but then when the backend broadcasts the event, it will read these fields from custom and add them to event.message_id and event.ai_state.
szuperaz
marked this pull request as ready for review
October 15, 2026 20:31
szuperaz
requested review from
MartinCupela,
isekovanic and
oliverlaz
as code owners
October 15, 2026 20:31
oliverlaz
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/stream/issue/REACT-1069/migrate-client-side-chat-qa-tests-to-v10-of-stream-chat-js
Migrates the docs-snippets test project from v9 -> v10. It contains all docs and platfrom stream-chat-js docs snippets we have. Relevant docs branch: https://github.com/GetStream/getstream.io/pull/683 (will be kept in sync with
getstream.io/mainuntil we're ready to release stream-chat-js).Most changes are to
docs-snippetproject, andsrc/gen, however, some client issues were found by the tests and those are fixed as well, so PR title isfix.Fixed client issues
Most changes are type fixes, 1-2 behavioral; here are the most important ones:
queryThreadsAndHydrate/getThreadAndHydratenow return the already-registeredThreadthrough the newThreadManager.resolveQueried. Before, they built a second instance thatactivate()and incoming events didn't reach. A registered thread that is out of date and not open gets refreshed from the query result.channel.sendEventmethod expected the response Event type, instead of the request. So it expected fields likecreated_at,custom. Fixed it, this method now expects the event request typeclient.devToken()is back (I think this was mistakenly removed with other server-side stuff)TODOs
Apart from the client changes in this PR, we have 3 small, pending todos to generator/open api spec. All tracked in the docs-todo file. The run also caught a bunch of smaller API behavior issues; since these issues are present on api v1 and v2 as well, they're not blocking us. I'll verify the findings and pass them to the backend team once I have the time.