Repository navigation
fix: ensure API errors parsing works even with multiple axios copies - #1909
Merged
szuperaz merged 1 commit intoOct 13, 2026
Conversation
szuperaz
requested review from
MartinCupela,
isekovanic and
oliverlaz
as code owners
October 12, 2026 16:05
isekovanic
approved these changes
Oct 12, 2026
oliverlaz
approved these changes
Oct 13, 2026
Member
|
@szuperaz @isekovanic shall we port this fix to v9 as well? |
MartinCupela
approved these changes
Oct 13, 2026
Contributor
Yes, we kinda have to, I believe it's important |
Contributor
Author
|
We don't need to backport this to v9, because it didn't use |
szuperaz
deleted the
fix-api-error-parsing-when-multiple-axios-instance-is-installed
branch
October 13, 2026 12:47
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
## [10.0.0-rc.22](v10.0.0-rc.21...v10.0.0-rc.22) (2026-10-16) ### ⚠ BREAKING CHANGES * `StreamChatOptions` and `client.options` are removed. `new StreamChat(key, config)` and `StreamChat.getInstance(key, config)` take the configuration tree (`DeepPartial<InstanceConfigTree>`) as their second argument; the `config` wrapper is dropped. Option moves: - `allowServerSideConnect`, `axiosRequestConfig`, `baseURL`, `browser`, `persistUserOnConnectionFailure` -> `client.<same name>` - `notifications` -> `client.notificationManager` - top-level axios fields (`timeout`, `httpsAgent`, ...) -> `client.axiosRequestConfig.<key>` Example: `new StreamChat(key, { client: { allowServerSideConnect: true } })`. `client.persistUserOnConnectionFailure` is no longer a field (use `client.config.setConfig('client', { persistUserOnConnectionFailure })`); `client.browser` and `client.node` are read-only getters. `baseURL`, `axiosRequestConfig` and `notificationManager` are read at construction, and the tree copies `axiosRequestConfig` instead of keeping your object. See v9-to-v10-migration-guide-client-construction.md. ### Bug Fixes * don't override local message attachments in createLinkPreviewsCo… ([#1885](#1885)) ([2aa5144](2aa5144)) * ensure API errors parsing works even with multiple axios copies ([#1909](#1909)) ([e0cfba9](e0cfba9)) * stability and perf fixes ([#1910](#1910)) ([080af2c](080af2c)) * type fixes from docs check; add docs snippet runner ([#1902](#1902)) ([2095fc1](2095fc1)) * type issues from platform docs check; add docs snippet test for the platform docs ([#1914](#1914)) ([c7706d2](c7706d2)) * **types:** add before_message_send_hook_system_messages to app settings response ([#1887](#1887)) ([724b4f7](724b4f7)) ### Features * add poll translation i18n fields ([#1878](#1878)) ([9d396e5](9d396e5)), closes [GetStream/chat#17029](https://github.com/GetStream/chat/issues/17029) * poll optimistic updates ([#1895](#1895)) ([e3dac59](e3dac59)) * replace StreamChatOptions with the configuration tree ([#1911](#1911)) ([f05b861](f05b861))
|
🎉 This PR is included in version 10.0.0-rc.22 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/stream/issue/REACT-1225/ensure-stream-chat-js-parses-api-error-correctly-if-multiple-axios
Noticed this while I was checking duplicate message id handling in v10. In RN SampleApp, this doesn't work correctly because SampleApp has two copies of axios:
stream-chatinstalled by SampleAppstream-chatcopyinstallNativeMultipartAdapter,it replaces SampleApp's axios adapter with the RN SDK's adapter copy anderror instanceof AxiosErrorwill always returnfalse, which meant errors weren't parsed properlyaxios, fixed here: fix: don't import axios into RN SDK stream-chat-react-native#3853isAxiosError(error)check, instead of relying oninstanceof