feat: add skip_truncate option to channel delete - #398
Merged
Conversation
Soft deleting a channel truncates it, so a channel recreated with the same ID comes back empty. The API now takes a skip_truncate option that preserves the history, as a query param on the single delete and a body field on the batch delete. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
mogita
requested review from
JimmyPettersson85,
hifaizsk,
nijeesh-stream and
slavabobik
as code owners
September 9, 2026 12:34
The struct is never marshaled, the batch request builds its own body struct, so the tag only suggested otherwise. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
yaziine
approved these changes
Sep 10, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
CHA-5241
Problem
Soft deleting a channel also truncates it, so a channel recreated with the same ID comes back empty and replies quoting older messages fail. The API gained a
skip_truncateoption that keeps the history, and this SDK cannot send it.Solution
Channel.Deletetakes variadicDeleteOptionvalues and sendsskip_truncate=trueas a query param whenDeleteWithSkipTruncate()is passed.Client.DeleteChannelstakes the same option and sendsskip_truncatein the body. Both omit the field when the option is absent, so existing calls are unchanged.The server owns the rules:
skip_truncateis rejected together with a hard delete, and only distinct channels are eligible.How to verify
go test -run SkipTruncate .passes. The two tests assert the query param and the body field are present when the option is set and absent when it is not.go build ./...passes.🤖 Generated with Claude Code