Repository navigation
Drop the stale isinstance claim from grail.md - #181
Open
MatiasFernandez wants to merge 2 commits into
Open
MatiasFernandez wants to merge 2 commits into
MatiasFernandez wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The bullet above the paragraph already describes the current behaviour, so the paragraph only needs to stop contradicting it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MatiasFernandez
changed the title
MatiasFernandez
marked this pull request as ready for review
October 27, 2026 21:12
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/grail.mdcontradicted itself aboutisinstanceafter a schema change.The bullet in the Brain Freeze findings says a schema change keeps
isinstancefor records written before it. The paragraph after the findings said that this "does not reproduce onc875e56": a schema change "no longer keepsisinstanceat all", so usetype(obj).__name__instead.The bullet is right for the pinned Grail. On
c8cbc92(engine 4.0.0.a5, 2026-10-27), and earlier onbeef473(engine 4.0.0.a4, 2026-10-20), a storedPersonwhose class is then edited to assign a new attribute (with or without a class attribute default), re-imported and committed, still passes bothisinstance(old, Person)andtype(old) is Person. This matches Grail's identity reuse: a rebuild reuses the class object.This PR removes the stale claim from that paragraph, along with the
type(obj).__name__advice. The paragraph's other claim, about a first call to a never-compiled function dirtying the session, stays as written, since I haven't re-measured it.Docs only, so no CHANGELOG entry.
🤖 Generated with Claude Code