Repository navigation
fix(sqlite): 读路径 SQL 文本构建收敛到专用构建器消 S2077 - #544
Conversation
SqliteDbService.Query.cs 三处 CommandText 表名内插改为调用新增私有静态 构建器 BuildSelectAllCommandText/BuildIdEqualsCommandText/BuildIdInCommandText， SQL 文本逐字节不变（无格式符内插等价 string.Concat 串联），id 值仍走 $id/$idN 参数绑定；表名为编译期封闭类型名的双引号转义、非运行期输入， SQL 标识符不可绑定参数，该不变量在构建器注释中声明。消除 Sonar csharpsquid:S2077 三处 MAJOR/VULNERABILITY 发现（GFX-889）。 Linear: GFX-889
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This change centralizes SQLite query-text construction while preserving the described SQL and parameter-binding behavior. No merge-blocking risk is identified. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
标题准确描述了主要变更：将 SQLite 读路径的 SQL 文本构建收敛到专用构建器，并处理 Sonar S2077 问题。 |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 1 files. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
1 participant
Linear: GFX-889
Summary by CodeRabbit