Repository navigation
Release 5.0.0: rebuild the desktop libraries, drop 32-bit Windows, remove the HTTP wiring - #1
Merged
Merged
Conversation
…P bridge automatically The Windows and Linux libraries were still the February 2022 builds, which carry an out-of-bounds read in the add*EventJson entry points. All three desktop libraries are now built from gameanalytics-sdk-cpp 424a87d by .github/workflows/desktop-binaries.yml, and the Windows and Linux paths in GameAnalytics.gml are re-enabled alongside them. 32-bit Windows is gone. It never built: the DLL's import library resolved to the same path as the C++ SDK's GameAnalytics.lib and MSVC refused it with LNK1149. Rather than add a ProxyFiles entry for a second Windows library, the x64 build now produces GameAnalytics.dll, which is the name GameAnalyticsExt.yy already declares and which carries the Windows bindings, so the extension needed no change and GameAnalytics_x64.dll - declared by nothing - is removed. Desktop uploads go through GameMaker's own http_request rather than linking cURL, and that needed three calls wired into an object by hand; forgetting one meant no data was ever sent, silently. ga_initialize() now creates obj_gameanalytics, which does it. The Async HTTP event is why this needs an object at all - GameMaker delivers async_load only to instances that define the event, so the bridge cannot live in a script or a time source. The object is looked up with asset_get_index so the scripts still compile when it has not been imported, and says so in the log instead of failing quietly. ga_http_pump, ga_http_handle_async and ga_http_abort stay public so a game can drive the bridge itself, and are safe to call alongside the object.
Nothing recorded which upstream SDK versions the shipped artifacts were built from. dependencies.json does, and download_externals.py brings the tree back in line with it: it fetches the C++ SDK source that DesktopSource builds and the JavaScript bundle, and reports on iOS and Android, which have nothing to download - the iOS releases publish no static library and the Android version is a Maven coordinate inside GameAnalyticsExt.yy, which the script checks rather than edits. CI now reads the C++ SDK ref from the manifest instead of keeping a second hardcoded copy. publish_release.py replaces the development repo's publish_gamemaker_release.py, which assumed two repositories, four version strings and a GMS1 .gmez. It bumps the two version strings, rebuilds on CI, verifies every shipped artifact, prepends the changelog, packages the extension, scripts and obj_gameanalytics, then tags and creates the release. It deliberately does not pull the old prebuilt libraries from download.gameanalytics.com: those are the February 2022 builds and taking them again would reintroduce the crash. The GameAnalytics key and secret it uses to check that the backend accepts the new sdk_version are read from internal/, which is gitignored, and it refuses to run if that file has become tracked.
The changelog entry was sitting under 4.1.0, which was never released from anywhere - this repository has no tags or releases, and the last release of the previous repository was 4.0.7. The entry describes this work, so it is 5.0.0. Major, because two things break for anyone moving from 4.0.7: 32-bit Windows is no longer supported and GameAnalytics_x64.dll is gone, and the SDK is now three resources rather than two, since obj_gameanalytics ships alongside the extension and the scripts. Both version strings move together: extensionVersion in GameAnalyticsExt.yy, which the IDE and the Marketplace show, and _sdkVersion in GameAnalytics.gml, which reaches the backend on every event.
…tics.dll The committed DLL was the x64 build from before the rename, copied into place by hand, so its PE export directory still named it GameAnalytics_x64.dll while the file on disk was GameAnalytics.dll. Replaced with the artifact from run 42014577859, which built it under the right name. All three desktop libraries now come byte-for-byte from that one green run.
Gogoshika-ga
approved these changes
Nov 6, 2026
dorin-ga
added a commit
that referenced
this pull request
Nov 6, 2026
GitHub retired every macOS 14 runner image from Actions on 2 November 2026, so the macos-universal job no longer starts: it is cancelled before its first step with "The configuration 'macos-14-arm64-us-default' is not supported". That is what happened to the run on the merge of #1, where linux-x64 and windows-x64 passed and only macOS was lost. macos-15 is the next supported arm64 image, so the universal build keeps cross-compiling x86_64 the same way it did on macos-14. Nothing about the library it produces changes: CMAKE_OSX_DEPLOYMENT_TARGET, not the runner version, is what sets the minimum macOS the extension supports, and that stays at 11.0. Also corrects the header comment, which still said four files to commit from the collected artifact after 32-bit Windows was dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop HTTP wiring is gone from the public API. Desktop uploads go through GameMaker's
http_requestrather than linking cURL, and that previously meant wiring three calls into an object by hand. Forget one and nothing was ever sent, silently.ga_initialize()now createsobj_gameanalytics, which does it:The Async HTTP event is why this needs an object at all: GameMaker delivers
async_loadonly to instances that define the event, so the bridge cannot live in a script or a time source. The object is resolved withasset_get_indexso the scripts still compile if it was not imported, and logs what is missing instead of failing quietly. The three functions stay public and safe to call for anyone who wants to drive the bridge themselves.