Repository navigation
[Chore] Updated Git attributes - #313
glektarssza wants to merge 3 commits into
Conversation
|
Addresses is not a proper keyword please see here https://help.github.com/articles/closing-issues-using-keywords/ |
|
Overall, this looks good. |
@PLASMAchicken fixed the PR description to use a proper keyword. |
| # Model formats are binary | ||
| *.[tT][cC][nN] binary | ||
|
|
||
| *[aA][uU][tT][oO][gG][eE][nN][eE][rR][aA][tT][eE][dD]* binary |
There was a problem hiding this comment.
I don't see a call out for why this was removed
There was a problem hiding this comment.
During my test builds and looking at other GTNH mods there does not seem to be a big need or use case for this being included as a default. There's nothing that matches this pattern in most mods or in the built files.
There was a problem hiding this comment.
@Guvante Do you have any further feedback, questions, comments, or concerns around this change? Or can I mark this as resolved?
4 participants
Closes #280. Also just generally cleaned up the file a bit.