Conversation
G00dS0ul
self-requested a review
September 20, 2026 10:31
G00dS0ul
marked this pull request as ready for review
September 20, 2026 10:31
G00dS0ul
marked this pull request as draft
September 20, 2026 10:33
Collaborator
Required Action ItemsPlease address the following items to align this PR with the project architecture and specifications:
|
…ing in status and process explorer screens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces comprehensive support for dynamic theme modes (Dark, Light, and System) and customizable accent colors across the UI. It establishes a modernized theme architecture under
lib/core/theme/, fixes mutual exclusivity issues in the Settings appearance panel, and resolves state reactivity bottlenecks that previously prevented theme changes from reflecting in real-time without a hot reload or restart.Key Changes
1. Theme System Architecture (
lib/core/theme/)HudColors(hud_colors.dart): Defines semantic dark and light color tokens (lightBgBase,darkBgBase,lightBgPanel,darkBgPanel, borders, text hierarchies) and dynamic accent color resolvers (cyan,green,amber,red,purple,blue).HudTextTheme(hud_text_theme.dart): Added typography styling tailored for both light and dark modes.HudTheme(hud_theme.dart): Generates dynamiclightTheme(accentColor)anddarkTheme(accentColor)ThemeDataconfigurations, with helperresolveThemeMode()to mapcyber_light,cyber_dark, andsystemto Flutter'sThemeMode.hudd_theme.dartand migrated imports across all screens and widgets.2. Settings Screen & Appearance Toggles (
settings_screen.dart)app.theme('cyber_dark','cyber_light','system') and removed the obsoleteappThemeboolean field fromAppearanceSettings.SettingsScreen's Scaffold to useTheme.of(context).scaffoldBackgroundColorinstead of hardcoding dark backgrounds.3. Immediate Theme Reactivity (
main.dart&settings_provider.dart)main.dart: Switched from selecting the mutableappearanceobject reference to observing primitive value strings (appearance.themeandappearance.accentColor) directly. This resolves Riverpod caching identical object instances and enables immediate, real-time UI re-renders without hot reload or app restart.updateUI()andsaveChanges()inSettingsNotifier(settings_provider.dart) to emit clonedcurrentSettingsinstances, ensuring proper state propagation across Riverpod listeners.Testing & Verification
test/widgets/settings_appearance_test.dart:test/widgets/theme_mode_rebuild_test.dart:MaterialAppimmediately rebuilds with updatedthemeModeupon state change.test/models/app_settings_test.dart:All unit and widget tests pass:
flutter test test/widgets/settings_appearance_test.dart test/widgets/theme_mode_rebuild_test.dart test/models/app_settings_test.dart