ci: add apptainer def and build ci (closes #91) - #92
Merged
Conversation
sahiljhawar
changed the title
Contributor
There was a problem hiding this comment.
🟡 Not ready to approve
Version tracking and CI publish reliability have concrete issues (bumpver points to a non-existent def filename, and GHCR push permissions are not explicitly granted).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR adds Apptainer container support so the project can build a .sif image from an Apptainer definition file and publish it to GitHub Container Registry (GHCR) via GitHub Actions.
Changes:
- Added
swvo.defApptainer definition (base image, labels, files, environment, dependency install, runscript). - Added
.github/workflows/apptainer.ymlto build the image and push it to GHCR with multiple tags. - Updated
pyproject.tomlbumpver patterns to include the Apptainer definition version (but currently points at the wrong filename).
File summaries
| File | Description |
|---|---|
swvo.def |
Introduces the Apptainer build recipe for SWVO. |
pyproject.toml |
Extends bumpver version propagation to the Apptainer definition file (currently mismatched filename). |
.github/workflows/apptainer.yml |
Adds CI to build and push the Apptainer image to GHCR on main pushes / manual runs. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 4
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces Apptainer container support for the project, enabling automated building and publishing of container images via GitHub Actions.
Added a new GitHub Actions workflow (
.github/workflows/apptainer.yml) to automatically build and push Apptainer images to GitHub Container Registry on every push tomainor manual dispatch. The workflow installs Apptainer, builds the image fromswvo.def, and pushes it with multiple tags (latest, commit SHA, and project version).Introduced an Apptainer definition file (
swvo.def) specifying the container build process, including base image, labels, file inclusion, environment variables, dependency installation, and runscript.Updated
pyproject.tomlto track the version inapptainer.deffor consistent version management across the codebase and container image.