Update submodule URL to relative path - #23
Merged
Conversation
Github runner needs https so it doesn't bother with ssh keys
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 830 830
=========================================
Hits 830 830 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@frankfeifan - Requesting review |
frankfeifan
reviewed
Aug 11, 2026
| [submodule "cmake/blt"] | ||
| path = cmake/blt | ||
| url = git@github.com:LLNL/blt.git | ||
| url = https://github.com/LLNL/blt.git |
Collaborator
There was a problem hiding this comment.
Suggested change
| url = https://github.com/LLNL/blt.git | |
| url = ../../LLNL/blt.git |
Collaborator
There was a problem hiding this comment.
please use the relative path which is more robust
frankfeifan
changed the title
frankfeifan
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github runner needs https so it doesn't bother with ssh keys