Skip to content

fix: three well unit tests on CUDA build #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bd713 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: three well unit tests on CUDA build #4116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95b0538
Fixed test 240
Aug 13, 2026
03ab46d
Fixed test 241
Aug 13, 2026
8861799
Fixed test 245
Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/coreComponents/integrationTests/wellsTests/testReservoirThermalSinglePhaseMSWells.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,9 @@ template< typename T, typename COL_INDEX >
void printCompareLocalMatrices( CRSMatrixView< T const, COL_INDEX const > const & matrix1,
CRSMatrixView< T const, COL_INDEX const > const & matrix2, std::string const & testName )
{
matrix1.move( hostMemorySpace, false );
matrix2.move( hostMemorySpace, false );

std::ofstream omat1( testName+".csv" );


Expand Down
3 changes: 3 additions & 0 deletions ...Components/integrationTests/wellsTests/testReservoirThermalSinglePhaseMSWells_RateInj.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,9 @@ template< typename T, typename COL_INDEX >
void printCompareLocalMatrices( CRSMatrixView< T const, COL_INDEX const > const & matrix1,
CRSMatrixView< T const, COL_INDEX const > const & matrix2, std::string const & testName )
{
matrix1.move( hostMemorySpace, false );
matrix2.move( hostMemorySpace, false );

std::ofstream omat1( testName+".csv" );


Expand Down
4 changes: 3 additions & 1 deletion src/coreComponents/integrationTests/wellsTests/testThermalEstimatorInjWell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,9 @@ template< typename T, typename COL_INDEX >
void printCompareLocalMatrices( CRSMatrixView< T const, COL_INDEX const > const & matrix1,
CRSMatrixView< T const, COL_INDEX const > const & matrix2, std::string const & testName )
{
matrix1.move( hostMemorySpace, false );
matrix2.move( hostMemorySpace, false );

std::ofstream omat1( testName+".csv" );


Expand Down Expand Up @@ -716,7 +719,6 @@ void testWellEstimatorNumericalJacobian( CompositionalMultiphaseReservoirAndWell
residual.zero();
jacobian.zero();
assembleFunction( jacobian.toViewConstSizes(), residual.toView() );
std::cout << "tjb dq iwelem " << iwelem << " " << (residual[25] - residualOrig[25])/dRate << std::endl;
fillNumericalJacobian( residual.toViewConst(),
residualOrig.toViewConst(),
wellElemDofNumber[iwelem] + compositionalMultiphaseWellKernels::ColOffset::DCOMP + NC,
Expand Down
3 changes: 3 additions & 0 deletions src/coreComponents/integrationTests/wellsTests/testThermalEstimatorProdWell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,9 @@ template< typename T, typename COL_INDEX >
void printCompareLocalMatrices( CRSMatrixView< T const, COL_INDEX const > const & matrix1,
CRSMatrixView< T const, COL_INDEX const > const & matrix2, std::string const & testName )
{
matrix1.move( hostMemorySpace, false );
matrix2.move( hostMemorySpace, false );

std::ofstream omat1( testName+".csv" );


Expand Down
3 changes: 3 additions & 0 deletions src/coreComponents/integrationTests/wellsTests/testThermalInjWell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ template< typename T, typename COL_INDEX >
void printCompareLocalMatrices( CRSMatrixView< T const, COL_INDEX const > const & matrix1,
CRSMatrixView< T const, COL_INDEX const > const & matrix2, std::string const & testName )
{
matrix1.move( hostMemorySpace, false );
matrix2.move( hostMemorySpace, false );

std::ofstream omat1( testName+".csv" );


Expand Down
3 changes: 3 additions & 0 deletions src/coreComponents/integrationTests/wellsTests/testThermalProdWell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ template< typename T, typename COL_INDEX >
void printCompareLocalMatrices( CRSMatrixView< T const, COL_INDEX const > const & matrix1,
CRSMatrixView< T const, COL_INDEX const > const & matrix2, std::string const & testName )
{
matrix1.move( hostMemorySpace, false );
matrix2.move( hostMemorySpace, false );

std::ofstream omat1( testName+".csv" );


Expand Down
3 changes: 3 additions & 0 deletions ...onents/integrationTests/wellsTests/testThermalReservoirCompositionalMultiphaseMSWells.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,9 @@ template< typename T, typename COL_INDEX >
void printCompareLocalMatrices( CRSMatrixView< T const, COL_INDEX const > const & matrix1,
CRSMatrixView< T const, COL_INDEX const > const & matrix2, std::string const & testName )
{
matrix1.move( hostMemorySpace, false );
matrix2.move( hostMemorySpace, false );

std::ofstream omat1( testName+".csv" );


Expand Down
38 changes: 23 additions & 15 deletions ...oreComponents/physicsSolvers/fluidFlow/wells/kernels/SinglePhaseWellConstraintKernels.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,11 @@ struct ConstraintHelper
wellElemGravCoef,
&dControlEqn,
&iwelemRef,
localRhs,
localMatrix,
controlEqn,
eqnRowIndex,
dofColIndices,
&refGravCoef] ( localIndex const )
{
real64 const diffGravCoef = refGravCoef - wellElemGravCoef[iwelemRef];
Expand All @@ -103,14 +108,13 @@ struct ConstraintHelper
{
dControlEqn[COFFSET_WJ::dT] = dDensity[iwelemRef][0][Deriv::dT] * diffGravCoef;
}
// add solver matrices
localRhs[eqnRowIndex] += controlEqn;
localMatrix.addToRowBinarySearchUnsorted< serialAtomic >( eqnRowIndex,
dofColIndices,
dControlEqn,
COFFSET_WJ::nDer );
} );

// add solver matrices
localRhs[eqnRowIndex] += controlEqn;
localMatrix.addToRowBinarySearchUnsorted< serialAtomic >( eqnRowIndex,
dofColIndices,
dControlEqn,
COFFSET_WJ::nDer );
}
template< template< typename U > class T, typename U=VolumeRateConstraint >
static void assembleConstraintEquation( real64 const & time_n,
Expand Down Expand Up @@ -166,7 +170,12 @@ struct ConstraintHelper
dDensity,
&dControlEqn,
&useSurfaceConditions,
&iwelemRef] ( localIndex const )
&iwelemRef,
localRhs,
localMatrix,
controlEqn,
eqnRowIndex,
dofColIndices] ( localIndex const )
{
// compute the inverse of the total density and derivatives
real64 const densInv = 1.0 / density[iwelemRef][0];
Expand All @@ -178,14 +187,13 @@ struct ConstraintHelper
dControlEqn[COFFSET_WJ::dT] = -( useSurfaceConditions == 0 ) * dDensity[iwelemRef][0][Deriv::dT] * currentVolRate * densInv;
}

// add solver matrices
localRhs[eqnRowIndex] += controlEqn;
localMatrix.addToRowBinarySearchUnsorted< serialAtomic >( eqnRowIndex,
dofColIndices,
dControlEqn,
COFFSET_WJ::nDer );
} );

// add solver matrices
localRhs[eqnRowIndex] += controlEqn;
localMatrix.addToRowBinarySearchUnsorted< serialAtomic >( eqnRowIndex,
dofColIndices,
dControlEqn,
COFFSET_WJ::nDer );
}
};

Expand Down
Loading