Skip to content

Update hypre/hypredrive builds on LC clusters - #4114

Merged
rrsettgast merged 11 commits into
developfrom
feature/castelletto1/enable_hypredrv
Aug 14, 2026
Merged

Update hypre/hypredrive builds on LC clusters#4114
rrsettgast merged 11 commits into
developfrom
feature/castelletto1/enable_hypredrv

Conversation

@castelletto1

Copy link
Copy Markdown
Collaborator

@castelletto1
castelletto1 requested a review from victorapm August 12, 2026 07:12
@castelletto1 castelletto1 self-assigned this Aug 12, 2026
@castelletto1 castelletto1 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Aug 12, 2026
@castelletto1 castelletto1 added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Aug 12, 2026
@castelletto1 castelletto1 added the flag: no rebaseline Does not require rebaseline label Aug 12, 2026
@castelletto1
castelletto1 requested a review from bd713 as a code owner August 12, 2026 07:12
@victorapm victorapm changed the title Enable hypredrive in all builds and update hypre Update hypre/hypredrive builds on LC clusters Aug 12, 2026

@victorapm victorapm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nicola!

I disabled hypredrive for the moment (LC users can still enable it if needed). I need to merge a few fixes proposed in #4108 first in order to enable hypredrive by default

@victorapm
victorapm requested a review from MelReyCG as a code owner August 14, 2026 00:14
@victorapm victorapm added flag: requires rebaseline Requires rebaseline branch in integratedTests and removed flag: no rebaseline Does not require rebaseline labels Aug 14, 2026
@victorapm

Copy link
Copy Markdown
Contributor

Needs rebaseline because we dropped writeLinearSystems="2" from a few input decks

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refreshes GEOS for the TPL bundle from thirdPartyLibs#357 while keeping Hypredrive opt-in.

Changes:

  • Updates LC host configurations and Hypre/Hypredrive paths.
  • Adds CI control for Hypredrive and compiler compatibility fixes.
  • Disables ATS linear-system dumps and updates integrated-test baselines.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/cmake/GeosxOptions.cmake Suppresses Clang 22 benchmark warnings.
scripts/ci_build_and_test_in_container.sh Adds Hypredrive build control.
.github/workflows/build_and_test.yml Exposes and forwards Hypredrive configuration.
.devcontainer/devcontainer.json Selects the updated TPL image.
.integrated_tests.yaml Updates the integrated-test baseline.
BASELINE_NOTES.md Documents the rebaseline.
inputFiles/singlePhaseWell/perf_status_test.xml Stops linear-system dumps.
inputFiles/lagrangianContactMechanics/LagrangeContactBubbleStab_singleFracCompression_base.xml Stops linear-system dumps.
inputFiles/immiscibleMultiphaseFlow/immiscible_2phaseFlow_1d.xml Stops linear-system dumps.
host-configs/LLNL/tuolumne-toss_4_x86_64_ib_cray-llvm-amdgpu@6.4.3-rocm@6.4.3.cmake Refreshes Tuolumne LLVM TPL paths.
host-configs/LLNL/tuolumne-toss_4_x86_64_ib_cray-cce@20.0.0-rocm@6.4.3.cmake Refreshes Tuolumne CCE TPL paths.
host-configs/LLNL/matrix-toss_4_x86_64_ib-llvm@19.1.3-cuda@12.9.1.cmake Refreshes Matrix LLVM 19 configuration.
host-configs/LLNL/matrix-toss_4_x86_64_ib-llvm@14.0.6-cuda@12.6.0.cmake Refreshes Matrix LLVM 14 configuration.
host-configs/LLNL/matrix-toss_4_x86_64_ib-gcc@13.3.1-cuda@12.9.1.cmake Refreshes Matrix GCC 13 configuration.
host-configs/LLNL/matrix-toss_4_x86_64_ib-gcc@12.1.1-cuda@12.6.0.cmake Refreshes Matrix GCC 12 configuration.
host-configs/LLNL/dane-toss_4_x86_64_ib-llvm@19.1.3.cmake Refreshes Dane LLVM 19 TPL paths.
host-configs/LLNL/dane-toss_4_x86_64_ib-llvm@14.0.6.cmake Refreshes Dane LLVM 14 TPL paths.
host-configs/LLNL/dane-toss_4_x86_64_ib-gcc@13.3.1.cmake Refreshes Dane GCC 13 configuration.
host-configs/LLNL/dane-toss_4_x86_64_ib-gcc@12.1.1.cmake Refreshes Dane GCC 12 TPL paths.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@rrsettgast
rrsettgast merged commit f5da31e into develop Aug 14, 2026
22 checks passed
@rrsettgast
rrsettgast deleted the feature/castelletto1/enable_hypredrv branch August 14, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants