refactor: Phase-field and damage solid model cleanup, refactor - #4096
refactor: Phase-field and damage solid model cleanup, refactor#4096frankfeifan wants to merge 21 commits into
Conversation
|
Added a few well-known benchmark examples in A short report summarizing these examples is attached here: |
…ctor' into refactor/frankfei/phaseFieldRefactor
…phaseFieldRefactor
…phaseFieldRefactor
| @@ -0,0 +1,3 @@ | |||
| version https://git-lfs.github.com/spec/v1 | |||
| oid sha256:2c27bd8a7f93400a56a2e1c746b1e120b2b37bfa9ae5b539db044e3eff4cf436 | |||
| size 10562784 | |||
There was a problem hiding this comment.
One concern is the size of the meshes for benchmark examples (xx MB), which is too large to be merged into develop repo.
Probably, they should be moved to the GEOSXDATA repo.
Can you also add the coarse version of these meshes for the corresponding smoke tests?
There was a problem hiding this comment.
I see this mesh has about 80k elements. Would it be possible to test the same simulation capabilities on a mesh with 1k elements? This would help speeding up the integrated tests and, at the same time, would solve the issue that Jian pointed out
There was a problem hiding this comment.
I see this mesh has about 80k elements. Would it be possible to test the same simulation capabilities on a mesh with 1k elements? This would help speeding up the integrated tests and, at the same time, would solve the issue that Jian pointed out
Thanks Victor. Actually these phase-field simulations have quite stringent mesh requirement. See Fig. 22 in https://onlinelibrary.wiley.com/doi/abs/10.1002/nme.2861
That said, I agree with Jian that move those large mesh files to the GEOSXDATA repo is a good plan. In GEOS, I can create coarse counterparts just for the integrated test purpose.
There was a problem hiding this comment.
That sounds a good plan, thanks, Frank!
| @@ -0,0 +1,3 @@ | |||
| version https://git-lfs.github.com/spec/v1 | |||
| oid sha256:e1c1f36ee6c041755fe55b5b7f4c08e611f3b7ef2891d68f3cc1095db10c58e6 | |||
| size 49152688 | |||
To remove dead codes, unify duplicated logic, rename unclear variables, and decouple crack model type from decomposition scheme to enable more options of the phase-field model.
LocalDissipationOptioninto a constitutive-level definitionFractureModelType(Brittle/Cohesive/Nucleation), and decouple it from decomposition scheme to allow for more phase-field model combinations, e.g.,- Brittle + Linear (AT1)/Quadratic (AT2) + No decomposition/Spectral/VolDev
- Cohesive + Linear + No decomposition/Spectral/VolDev
- Nucleation + Linear + No decomposition
PhaseFieldFractureorPhaseFieldDamageFEM.Still wip, and more to come ...