Closed - opened by mistake - #324
Closed
NicholasBolen wants to merge 1 commit into
Closed
Conversation
The addon formats a temporary copy of the script instead of the file itself, to avoid Godot's "file changed outside of Godot" pop-up. That copy was written to the system's temporary folder, but the formatter discovers `.editorconfig` by walking up the folders above the file it formats. From `/tmp` it never reaches the project, so every editorconfig-only setting was silently dropped when formatting from the Godot editor, while the same file formatted correctly from the CLI. Writing the temporary copy next to the original script puts it back under the project's `.editorconfig`. The file name starts with a dot so Godot's filesystem scanner skips it while it briefly exists. Fixes GDQuest#315
NicholasBolen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing this, just testing locally. Sorry for the noise.