Repository navigation
fix(chat): polish queued messages as an integrated composer tray - #3776
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Queued messages previously appeared as a separate gray card with a prominent heading and repeated icon actions. Present both host and legacy queues as a softly outlined tray joined to the composer: brighter message text, a leading queue marker, and always-visible Send now, remove and more actions. Expanded queues omit the heading; editing, collapse and host help live in the row menu. Narrow trays shorten Send now to its icon while retaining the accessible label and tooltip.
Type and Areas
Type: UI/UX and bug fix
Areas: Web UI and shared design-system composer components
Motivation / Impact
aria-expanded.Verification
Passed locally:
pnpm run check:web— type-check, typography, appearance, theme color and visual contractspnpm run i18n:audit;pnpm run motion:audit— motion inventory reviewednode --test design-system/packages/ui/tests/*.test.mjsafter package build — 351 testsnode --test src/mobile-web/tests/host-dialog-queue.test.mjs— 17 host/outbox contract testspnpm --dir src/web-ui run icons:check; focused ESLint on changed queue components and hook;git diff --checkFocused queue verification commands are documented in the owning guides. Queue tests use real shared UI components, including portalled menus, rather than mocking their interactions.
Reviewer Notes
Pre-edit local-history review found
df4e7907b6already compacted the host panel; the shared queue still painted a separate background inside the context tray. This builds on that implementation.Queue transport, persistence and capability negotiation are unchanged. Tests exercise local DOM behavior, a simulated Peer surface switch and simulated host/outbox recovery. Live SSH, Remote Control, Peer Device and Detached Dispatch were not exercised. Native visual fidelity, light/dark appearance and physical touch behavior have not been manually verified.
The broader
design-system:testsuite has two existingGenOfficeFilecatalog expectation failures inflow-chat-presentation, reproduced in the unchanged primary checkout. They are outside this change; the shared UI package tests pass.Checklist