fix(peer): restore terminal control and file downloads#1666
Merged
bobleer merged 1 commit intoJul 21, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root causes
The native save dialog runs on controller A, but export_local_file_to_path was HostInvoked on peer B. That made B attempt to write an A-local path and could return Windows access denied (os error 5). Directory downloads also reached std::fs::copy, which cannot copy a directory.
SSH-backed PTY events were emitted only to the peer desktop webview, terminal RPCs could sit behind two background requests, and remote terminal signals returned success without affecting the PTY.
Validation
Physical Windows to macOS peer smoke testing is still recommended before release.