fix(relay): delete devices atomically#1665
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
404 Not Foundfor devices outside the account and add route-level regression testsWhy
auth_tokens.device_idreferencesdevices.device_id, so deleting the device first can fail while active tokens exist. The previous deletion was also not scoped byuser_id. The transactional helper preserves referential integrity and prevents partial or cross-account deletion.Test plan
cargo test -p bitfun-relay-servicenode scripts/check-core-boundaries.mjscargo check --workspacegit diff --checkAI-assisted: yes. Testing level: fully tested with automated Rust checks.