Repository navigation
Fix GTK activation and Builder MO rendering - #565
Merged
Merged
Conversation
Collaborator
|
Thanks. Tested before merging: summary_test (with the new scroll check), orca_mo_test, ecceqm_mo_large_test, mo_explore_workflow_test, organizer_close_test and the 72-app smoke suite, all passing on a build of this branch (Xvfb, llvmpipe). Lycopene MOs (NWChem, ORCA, G16, ECCE-QM, MOPAC) did not crash on main under llvmpipe either, so the original crash may depend on the students' GL driver; #566 follows up with renderer detection. A glxinfo -B line from an affected machine would help there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ewxRaiseWindow()in GTK activation paths to avoid timestamp-zero window-manager warnings.Validation
cmake --build /home/asplund/build/ECCE/build-cmake/9.3.3-rpm --target builder -j 8passed after rebasing ontomain.BUILD_TESTING=OFF).maincommit (c9bd11fa) reports the identical failures, and this PR does not change parser files.