Repository navigation
fix(#401): Security: file-request visitor places unbounded files when no file limit is set - #410
Merged
Merged
Conversation
Bounded files per file request (1000 ceiling, 100 per visitor, counted placed plus open) and rate-limited visitor upload creation (60/min per request+visitor and per address); now also LocalBackend.dropUpload deletes a visitor's unplaced file_request_uploads row together with its dropped upload (SIZE_MISMATCH overrun, expiry), and migration 032 removes such orphans, so overrunning uploads can no longer grow the table without bound. Adversarial and test-adversary reviews ran; the test adversary's blocking gap (the cloud-placed row's placed_at guard) is now pinned by the cloud test, and the PATCH ceiling and German hint wording were fixed. Refs #401 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BeSovereign
force-pushed
the
fix/issue-401
branch
from
October 20, 2026 08:59
35277ea to
348b6b7
Compare
Contributor
Author
|
Security review (claude-fable-5-1): no blocking finding. Caps and rate limit are enforced atomically and synchronously, visitor ids are signed, address folding only tightens, no orphan rows, tests flip when each check is removed. Non-blocking: per-visitor cap is cookie-keyed by design; a request can be griefed to its 1000 ceiling with empty files and placed rows never free up; password limiter keys raw req.ip unlike the creation limiter; /info has no rate limit (pre-existing). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #401
Bounded files per file request (1000 ceiling, 100 per visitor, counted placed plus open) and rate-limited visitor upload creation (60/min per request+visitor and per address); now also LocalBackend.dropUpload deletes a visitor's unplaced file_request_uploads row together with its dropped upload (SIZE_MISMATCH overrun, expiry), and migration 032 removes such orphans, so overrunning uploads can no longer grow the table without bound. Adversarial and test-adversary reviews ran; the test adversary's blocking gap (the cloud-placed row's placed_at guard) is now pinned by the cloud test, and the PATCH ceiling and German hint wording were fixed.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code