Skip to content

fix(#390): File request 'Files' dialog: a row's date wraps back under the file icon - #400

Open
BeSovereign wants to merge 1 commit into
mainfrom
fix/issue-390
Open

BeSovereign wants to merge 1 commit into
mainfrom
fix/issue-390

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #390

The Files dialog's rows are now stacked rows: the size and date come first in a .received-facts line (followed by the 'Neu' pill and sender) on its own line, indented to the name, with a fixed-width size slot so every date stands at the same x (FileRequestsView.vue, app.css, DESIGN.md/DECISIONS.md). The new #390 test's extra folder pushed the shared home folder past the 200-entry windowing threshold, so collision.spec.ts now works in a per-test folder instead of relying on home staying small.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1176 passed, 0 failed | e2e: 601 passed, 0 failed
  • Red/green check on declared tests: e2e/file-requests.spec.ts, e2e/collision.spec.ts
red/green output
RED without the change:
Fil-2bd73-nder-the-name-at-the-same-x-mobile-chrome/error-context.md

    attachment #4: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/file-requests--390-the-Fil-2bd73-nder-the-name-at-the-same-x-mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/file-requests--390-the-Fil-2bd73-nder-the-name-at-the-same-x-mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  2 failed
    [desktop-chrome] › e2e/file-requests.spec.ts:285:1 › #390 the Files dialog puts every row's date under the name, at the same x 
    [mobile-chrome] › e2e/file-requests.spec.ts:285:1 › #390 the Files dialog puts every row's date under the name, at the same x 


GREEN with the change:
tation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/file-requests.spec.ts:285:1 › #390 the Files dialog puts every row's date under the name, at the same x (1.2s)
  ✓  2 [mobile-chrome] › e2e/file-requests.spec.ts:285:1 › #390 the Files dialog puts every row's date under the name, at the same x (1.3s)

  2 passed (5.0s)

🤖 Generated with Claude Code

The Files dialog's rows are now stacked rows: the size and date come first in a `.received-facts` line (followed by the 'Neu' pill and sender) on its own line, indented to the name, with a fixed-width size slot so every date stands at the same x (FileRequestsView.vue, app.css, DESIGN.md/DECISIONS.md). The new #390 test's extra folder pushed the shared home folder past the 200-entry windowing threshold, so collision.spec.ts now works in a per-test folder instead of relying on home staying small.

Refs #390

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant