Skip to content

fix(#387, #388, #389): Migration review and job page: figures in the UI face; destination written as a - #399

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-387-388-389
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-387-388-389

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #387 #388 #389

#387: the migration review and job page write the destination through location.ts as 'My storage › …', set counts and sizes in mono, and put the fact labels on their values' baseline. #388: the reserve default minimum comes from the shared DEFAULT_RESERVE bytes and is formatted with formatSize (5.4 GB), and reserveMin is gone from the locales. #389: with two panes the transfer/upload panel loses its 960 px cap and lines up with the right pane. The E2E titles now name each issue so the per-issue grep finds them.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1176 passed, 0 failed | e2e: 599 passed, 0 failed
  • Red/green check on declared tests: e2e/migration.spec.ts, e2e/storage.spec.ts, e2e/disk-reserve.spec.ts, server/test/diskReserve.test.ts, e2e/dual-pane.spec.ts
red/green output
## #387
RED without the change:
e/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/migration-migrate-a-cloud--376ff-the-verified-originals-387--mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/migration-migrate-a-cloud--376ff-the-verified-originals-387--mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  2 failed
    [desktop-chrome] › e2e/migration.spec.ts:42:1 › migrate a cloud folder with the wizard, read the summary, and delete only the verified originals (#387) 
    [mobile-chrome] › e2e/migration.spec.ts:42:1 › migrate a cloud folder with the wizard, read the summary, and delete only the verified originals (#387) 


GREEN with the change:
ition of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/migration.spec.ts:42:1 › migrate a cloud folder with the wizard, read the summary, and delete only the verified originals (#387) (1.5s)
  ✓  2 [mobile-chrome] › e2e/migration.spec.ts:42:1 › migrate a cloud folder with the wizard, read the summary, and delete only the verified originals (#387) (1.5s)

  2 passed (5.4s)


## #388
RED without the change:
serve sentence writes the default minimum in decimal units 
    [mobile-chrome] › e2e/disk-reserve.spec.ts:19:1 › the storage page shows the admin the shard’s disk and the default reserve; a member sees neither 
    [mobile-chrome] › e2e/disk-reserve.spec.ts:69:3 › de-du: the reserve sentence sets the reserve and the default's figures in the mono face (#370) 
    [mobile-chrome] › e2e/disk-reserve.spec.ts:69:3 › de-sie: the reserve sentence sets the reserve and the default's figures in the mono face (#370) 
    [mobile-chrome] › e2e/disk-reserve.spec.ts:69:3 › en: the reserve sentence sets the reserve and the default's figures in the mono face (#370) 
    [mobile-chrome] › e2e/storage.spec.ts:12:1 › #388: the reserve sentence writes the default minimum in decimal units 
  14 passed (1.2m)


GREEN with the change:
me] › e2e/storage.spec.ts:98:1 › a member who opens the members page sees one banner with the way to “My storage”, not the admin’s intro (#316) (484ms)
  ✓  21 [mobile-chrome] › e2e/storage.spec.ts:115:1 › the members page shows the row skeleton while it loads, and the intro only with the table (#316) (479ms)
  ✓  22 [mobile-chrome] › e2e/storage.spec.ts:128:1 › the storage breakdown sets its sizes in the mono face (#317) (383ms)
  ✓  23 [mobile-chrome] › e2e/storage.spec.ts:143:3 › with a cloud account › the overview shows a usage bar per source and the largest folders of the home (899ms)
  ✓  24 [mobile-chrome] › e2e/storage.spec.ts:186:3 › with a cloud account › a SharePoint library whose drive reports no quota shows its usage as unknown, not an error (#205) (1.1s)

  24 passed (18.7s)


## #389
RED without the change:
──────────────────────────────────────────────────────────────────

    Error Context: test-results/dual-pane--389-with-two-pa-a247e-s-where-the-right-pane-ends-desktop-chrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/dual-pane--389-with-two-pa-a247e-s-where-the-right-pane-ends-desktop-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/dual-pane--389-with-two-pa-a247e-s-where-the-right-pane-ends-desktop-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  1 failed
    [desktop-chrome] › e2e/dual-pane.spec.ts:174:1 › #389: with two panes the transfer panel ends where the right pane ends 
  1 skipped


GREEN with the change:
s an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/dual-pane.spec.ts:174:1 › #389: with two panes the transfer panel ends where the right pane ends (1.1s)
  -  2 [mobile-chrome] › e2e/dual-pane.spec.ts:174:1 › #389: with two panes the transfer panel ends where the right pane ends

  1 skipped
  1 passed (3.9s)

🤖 Generated with Claude Code

…UI face; desti

#387: the migration review and job page write the destination through location.ts as 'My storage › …', set counts and sizes in mono, and put the fact labels on their values' baseline. #388: the reserve default minimum comes from the shared DEFAULT_RESERVE bytes and is formatted with formatSize (5.4 GB), and reserveMin is gone from the locales. #389: with two panes the transfer/upload panel loses its 960 px cap and lines up with the right pane. The E2E titles now name each issue so the per-issue grep finds them.

Refs #387 #388 #389

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant