Repository navigation
fix(#386): Phone details drawer: 'Add tag' touches the field above it; tag remove X is a 22 - #398
Merged
Merged
Conversation
Gave .tag-add an 8 px row gap (the label's margin offsets it so the label stays 5 px above the field) and, below 600 px, gave .tag-remove a ::after layer with inset -11px for a 44 px hit area; the X glyph and chip keep their size. New mobile Playwright test checks the gap, the hit area at ±15 px from the X's centre and a real off-centre tap. Refs #386 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #386
Gave .tag-add an 8 px row gap (the label's margin offsets it so the label stays 5 px above the field) and, below 600 px, gave .tag-remove a ::after layer with inset -11px for a 44 px hit area; the X glyph and chip keep their size. New mobile Playwright test checks the gap, the hit area at ±15 px from the X's centre and a real off-centre tap.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code