Skip to content

fix(#386): Phone details drawer: 'Add tag' touches the field above it; tag remove X is a 22 - #398

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-386
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-386

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #386

Gave .tag-add an 8 px row gap (the label's margin offsets it so the label stays 5 px above the field) and, below 600 px, gave .tag-remove a ::after layer with inset -11px for a 44 px hit area; the X glyph and chip keep their size. New mobile Playwright test checks the gap, the hit area at ±15 px from the X's centre and a real off-centre tap.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1176 passed, 0 failed | e2e: 596 passed, 0 failed
  • Red/green check on declared tests: e2e/tags.spec.ts
red/green output
RED without the change:
─────────────────────────────────────────

    Error Context: test-results/tags--386-on-phone-width-t-446cd-move-X-has-a-44-px-hit-area-mobile-chrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/tags--386-on-phone-width-t-446cd-move-X-has-a-44-px-hit-area-mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/tags--386-on-phone-width-t-446cd-move-X-has-a-44-px-hit-area-mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  1 failed
    [mobile-chrome] › e2e/tags.spec.ts:191:1 › #386 on phone width the add-tag button keeps 8 px to the field and the tag remove X has a 44 px hit area 
  1 skipped


GREEN with the change:
sition of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  -  1 [desktop-chrome] › e2e/tags.spec.ts:191:1 › #386 on phone width the add-tag button keeps 8 px to the field and the tag remove X has a 44 px hit area
  ✓  2 [mobile-chrome] › e2e/tags.spec.ts:191:1 › #386 on phone width the add-tag button keeps 8 px to the field and the tag remove X has a 44 px hit area (1.0s)

  1 skipped
  1 passed (4.0s)

🤖 Generated with Claude Code

Gave .tag-add an 8 px row gap (the label's margin offsets it so the label stays 5 px above the field) and, below 600 px, gave .tag-remove a ::after layer with inset -11px for a 44 px hit area; the X glyph and chip keep their size. New mobile Playwright test checks the gap, the hit area at ±15 px from the X's centre and a real off-centre tap.

Refs #386

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit fd11295 into main Oct 20, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-386 branch October 20, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant