Skip to content

fix(#384): Duplicates page: teal group frames, figures not in mono, 18 px checkboxes on pho - #396

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-384
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-384

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #384

Duplicate groups are now list sheets (surface background, --border frame and row lines instead of the teal --line). The size and date are mono spans via i18n-t slots, each checkbox sits in a label.check-target that reuses the file list's 44 px phone rule, and the 'Where to look' legend has padding 0. A new Playwright spec checks all four on desktop and phone in the dark theme.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1176 passed, 0 failed | e2e: 592 passed, 0 failed
  • Red/green check on declared tests: e2e/duplicates-design.spec.ts
red/green output
RED without the change:
-chrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/duplicates-design--384-dup-8fb88-heckbox-labels-on-the-phone-mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/duplicates-design--384-dup-8fb88-heckbox-labels-on-the-phone-mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  2 failed
    [desktop-chrome] › e2e/duplicates-design.spec.ts:41:1 › #384 duplicates: groups are list sheets, figures in mono, 44 px checkbox labels on the phone 
    [mobile-chrome] › e2e/duplicates-design.spec.ts:41:1 › #384 duplicates: groups are list sheets, figures in mono, 44 px checkbox labels on the phone 


GREEN with the change:
 position of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/duplicates-design.spec.ts:41:1 › #384 duplicates: groups are list sheets, figures in mono, 44 px checkbox labels on the phone (920ms)
  ✓  2 [mobile-chrome] › e2e/duplicates-design.spec.ts:41:1 › #384 duplicates: groups are list sheets, figures in mono, 44 px checkbox labels on the phone (963ms)

  2 passed (4.4s)

🤖 Generated with Claude Code

Duplicate groups are now list sheets (surface background, --border frame and row lines instead of the teal --line). The size and date are mono spans via i18n-t slots, each checkbox sits in a label.check-target that reuses the file list's 44 px phone rule, and the 'Where to look' legend has padding 0. A new Playwright spec checks all four on desktop and phone in the dark theme.

Refs #384

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit 232a94b into main Oct 20, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-384 branch October 20, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant