Skip to content

fix(#383): Two panes in German: selection bar stacks into six rows and pushes the list down - #395

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-383
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-383

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #383

Inside a pane of the two-pane layout, the toolbar now wraps while a selection lasts and the selection bar takes flex-basis 100%, right-aligned under the title, instead of squeezing six rows beside a cut 8rem crumb. The German bar fills 4 full-width rows rather than the issue's estimated 2-3 (about 1580 px of buttons, fixed order, guide button size kept); this is recorded in DECISIONS.md and DESIGN.md. The new Playwright test checks at most 4 rows, the bar below the crumb, the crumb not cut, and the list moving by at most the bar's height.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1176 passed, 0 failed | e2e: 590 passed, 0 failed
  • Red/green check on declared tests: e2e/selection-bar.spec.ts
red/green output
RED without the change:
─────────────────────────────────────────────────

    Error Context: test-results/selection-bar--383-in-a-pa-f4ae2-der-the-title-not-beside-it-desktop-chrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/selection-bar--383-in-a-pa-f4ae2-der-the-title-not-beside-it-desktop-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/selection-bar--383-in-a-pa-f4ae2-der-the-title-not-beside-it-desktop-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  1 failed
    [desktop-chrome] › e2e/selection-bar.spec.ts:132:1 › #383 in a pane of two the German selection bar wraps under the title, not beside it 
  1 skipped


GREEN with the change:
interpret due to the position of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/selection-bar.spec.ts:132:1 › #383 in a pane of two the German selection bar wraps under the title, not beside it (745ms)
  -  2 [mobile-chrome] › e2e/selection-bar.spec.ts:132:1 › #383 in a pane of two the German selection bar wraps under the title, not beside it

  1 skipped
  1 passed (3.3s)

🤖 Generated with Claude Code

Inside a pane of the two-pane layout, the toolbar now wraps while a selection lasts and the selection bar takes flex-basis 100%, right-aligned under the title, instead of squeezing six rows beside a cut 8rem crumb. The German bar fills 4 full-width rows rather than the issue's estimated 2-3 (about 1580 px of buttons, fixed order, guide button size kept); this is recorded in DECISIONS.md and DESIGN.md. The new Playwright test checks at most 4 rows, the bar below the crumb, the crumb not cut, and the list moving by at most the bar's height.

Refs #383

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit 65bbe37 into main Oct 20, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-383 branch October 20, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant