Skip to content

fix(#382): Details drawer says “Only you.” under “Who has access” while the item has public - #394

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-382
Oct 20, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-382

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #382

The details drawer now also loads the item's public links (GET /api/v1/links, as LinkManager does) and lists the active ones (not expired, downloads left) under "Who has access" with an "Anyone with the link" pill; "Only you." shows only with neither member shares nor active links. Strings are in all three locales, and the decision is recorded in DECISIONS.md and DESIGN.md.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1176 passed, 0 failed | e2e: 589 passed, 0 failed
  • Red/green check on declared tests: e2e/details-access.spec.ts
red/green output
RED without the change:
ment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/details-access--382-the-de-4698d-Only-you-once-it-is-revoked-mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/details-access--382-the-de-4698d-Only-you-once-it-is-revoked-mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  2 failed
    [desktop-chrome] › e2e/details-access.spec.ts:24:1 › #382: the details drawer lists an active public link under "Who has access" and is "Only you." once it is revoked 
    [mobile-chrome] › e2e/details-access.spec.ts:24:1 › #382: the details drawer lists an active public link under "Who has access" and is "Only you." once it is revoked 


GREEN with the change:
nt will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/details-access.spec.ts:24:1 › #382: the details drawer lists an active public link under "Who has access" and is "Only you." once it is revoked (998ms)
  ✓  2 [mobile-chrome] › e2e/details-access.spec.ts:24:1 › #382: the details drawer lists an active public link under "Who has access" and is "Only you." once it is revoked (1.0s)

  2 passed (4.4s)

🤖 Generated with Claude Code

The details drawer now also loads the item's public links (GET /api/v1/links, as LinkManager does) and lists the active ones (not expired, downloads left) under "Who has access" with an "Anyone with the link" pill; "Only you." shows only with neither member shares nor active links. Strings are in all three locales, and the decision is recorded in DECISIONS.md and DESIGN.md.

Refs #382

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit 7a66cc9 into main Oct 20, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-382 branch October 20, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant