Repository navigation
fix(#381): Details drawer: Add tag, remove tag and Send drop focus to the page; Esc then fa - #393
Merged
Merged
Conversation
TagEditor now refocuses the tag field after Add and moves the focus to the next chip's remove button (or the field) after removing a tag; CommentThread.send() refocuses the composer. The focus no longer falls to <body>, so Esc still closes the details drawer; e2e/drawer-focus.spec.ts covers all three keyboard flows on desktop and mobile Chrome. Refs #381 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #381
TagEditor now refocuses the tag field after Add and moves the focus to the next chip's remove button (or the field) after removing a tag; CommentThread.send() refocuses the composer. The focus no longer falls to , so Esc still closes the details drawer; e2e/drawer-focus.spec.ts covers all three keyboard flows on desktop and mobile Chrome.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code