Skip to content

fix(#381): Details drawer: Add tag, remove tag and Send drop focus to the page; Esc then fa - #393

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-381
Oct 19, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-381

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #381

TagEditor now refocuses the tag field after Add and moves the focus to the next chip's remove button (or the field) after removing a tag; CommentThread.send() refocuses the composer. The focus no longer falls to , so Esc still closes the details drawer; e2e/drawer-focus.spec.ts covers all three keyboard flows on desktop and mobile Chrome.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1176 passed, 0 failed | e2e: 587 passed, 0 failed
  • Red/green check on declared tests: e2e/drawer-focus.spec.ts
red/green output
RED without the change:
s on the tag field and Esc closes the drawer 
    [desktop-chrome] › e2e/drawer-focus.spec.ts:47:1 › #381 removing a tag moves the focus to the next chip, then to the tag field, and Esc closes the drawer 
    [desktop-chrome] › e2e/drawer-focus.spec.ts:67:1 › #381 "Send" from the keyboard leaves the focus on the composer and Esc closes the drawer 
    [mobile-chrome] › e2e/drawer-focus.spec.ts:34:1 › #381 "Add tag" from the keyboard leaves the focus on the tag field and Esc closes the drawer 
    [mobile-chrome] › e2e/drawer-focus.spec.ts:47:1 › #381 removing a tag moves the focus to the next chip, then to the tag field, and Esc closes the drawer 
    [mobile-chrome] › e2e/drawer-focus.spec.ts:67:1 › #381 "Send" from the keyboard leaves the focus on the composer and Esc closes the drawer 


GREEN with the change:
 › e2e/drawer-focus.spec.ts:47:1 › #381 removing a tag moves the focus to the next chip, then to the tag field, and Esc closes the drawer (749ms)
  ✓  3 [desktop-chrome] › e2e/drawer-focus.spec.ts:67:1 › #381 "Send" from the keyboard leaves the focus on the composer and Esc closes the drawer (676ms)
  ✓  4 [mobile-chrome] › e2e/drawer-focus.spec.ts:34:1 › #381 "Add tag" from the keyboard leaves the focus on the tag field and Esc closes the drawer (758ms)
  ✓  5 [mobile-chrome] › e2e/drawer-focus.spec.ts:47:1 › #381 removing a tag moves the focus to the next chip, then to the tag field, and Esc closes the drawer (850ms)
  ✓  6 [mobile-chrome] › e2e/drawer-focus.spec.ts:67:1 › #381 "Send" from the keyboard leaves the focus on the composer and Esc closes the drawer (854ms)

  6 passed (7.1s)

🤖 Generated with Claude Code

TagEditor now refocuses the tag field after Add and moves the focus to the next chip's remove button (or the field) after removing a tag; CommentThread.send() refocuses the composer. The focus no longer falls to <body>, so Esc still closes the details drawer; e2e/drawer-focus.spec.ts covers all three keyboard flows on desktop and mobile Chrome.

Refs #381

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit 62183e5 into main Oct 19, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-381 branch October 19, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant