Repository navigation
fix(#380): Security (low): transfer scheduler is one global FIFO; one member can stall ever - #392
Merged
Merged
Conversation
Likely CI cause (logs were not accessible): pump() broke same-millisecond created_at ties by the random job id, so a member's later job could start before an earlier one and the scheduling tests' order assumptions failed depending on host speed; ties now go by rowid (insertion order), pinned by a frozen-clock test with 10 jobs. Also added a test that a cleanup refused with JOB_LIMIT keeps its token (the early assertJobRoom guard), after the two sequential reviews; DECISIONS.md updated. Refs #380 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
BeSovereign
force-pushed
the
fix/issue-380
branch
from
October 19, 2026 21:43
0321e27 to
f3377e1
Compare
Contributor
Author
|
Security review (claude-fable-5-1): no blocking finding. Cap is atomic inside the immediate insert transaction and keyed on the session user; cleanup pre-check precedes token burn with no await; scheduler alternates by job owner and cannot be spoofed; new SQL parameterised, rowid valid; tests fail without each check. Remaining: item count per job still unbounded via folder expansion (pre-existing), slot turns are per grant not per byte (accepted in DECISIONS). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #380
Likely CI cause (logs were not accessible): pump() broke same-millisecond created_at ties by the random job id, so a member's later job could start before an earlier one and the scheduling tests' order assumptions failed depending on host speed; ties now go by rowid (insertion order), pinned by a frozen-clock test with 10 jobs. Also added a test that a cleanup refused with JOB_LIMIT keeps its token (the early assertJobRoom guard), after the two sequential reviews; DECISIONS.md updated.
Driver gates (measured, not claimed)
red/green output
🤖 Generated with Claude Code