Skip to content

fix(#370, #371, #372): Storage usage: disk reserve sentence not in the mono face; '5 %' spacing wrong i - #378

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-370-371-372
Oct 19, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-370-371-372

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #370 #371 #372

#370 renders the reserve sentence with and .value-mono slots and fixes the percentage spacing (U+00A0 in de, '5%' in en); #371 adds margin-bottom: var(--space-4) to .link-new; #372 gives the drawer's tag field a visible .fs-label and drops the placeholder. Fixed the #372 E2E flake (403 from reading the CSRF token before the login redirect finished) by waiting for the nav first, as the file's other tests do.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1167 passed, 0 failed | e2e: 579 passed, 0 failed
  • Red/green check on declared tests: e2e/disk-reserve.spec.ts, e2e/public-link-list.spec.ts, e2e/tags.spec.ts
red/green output
## #370
RED without the change:
 and the default's figures in the mono face (#370) 
    [desktop-chrome] › e2e/disk-reserve.spec.ts:69:3 › de-sie: the reserve sentence sets the reserve and the default's figures in the mono face (#370) 
    [desktop-chrome] › e2e/disk-reserve.spec.ts:69:3 › en: the reserve sentence sets the reserve and the default's figures in the mono face (#370) 
    [mobile-chrome] › e2e/disk-reserve.spec.ts:69:3 › de-du: the reserve sentence sets the reserve and the default's figures in the mono face (#370) 
    [mobile-chrome] › e2e/disk-reserve.spec.ts:69:3 › de-sie: the reserve sentence sets the reserve and the default's figures in the mono face (#370) 
    [mobile-chrome] › e2e/disk-reserve.spec.ts:69:3 › en: the reserve sentence sets the reserve and the default's figures in the mono face (#370) 


GREEN with the change:
hrome] › e2e/disk-reserve.spec.ts:69:3 › de-sie: the reserve sentence sets the reserve and the default's figures in the mono face (#370) (563ms)
  ✓  3 [desktop-chrome] › e2e/disk-reserve.spec.ts:69:3 › en: the reserve sentence sets the reserve and the default's figures in the mono face (#370) (529ms)
  ✓  4 [mobile-chrome] › e2e/disk-reserve.spec.ts:69:3 › de-du: the reserve sentence sets the reserve and the default's figures in the mono face (#370) (667ms)
  ✓  5 [mobile-chrome] › e2e/disk-reserve.spec.ts:69:3 › de-sie: the reserve sentence sets the reserve and the default's figures in the mono face (#370) (625ms)
  ✓  6 [mobile-chrome] › e2e/disk-reserve.spec.ts:69:3 › en: the reserve sentence sets the reserve and the default's figures in the mono face (#370) (580ms)

  6 passed (6.4s)


## #371
RED without the change:
ialog’s-action-row-371--mobile-chrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/public-link-list-the-“New--29ccb-he-dialog’s-action-row-371--mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/public-link-list-the-“New--29ccb-he-dialog’s-action-row-371--mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  2 failed
    [desktop-chrome] › e2e/public-link-list.spec.ts:157:1 › the “New public link” button keeps 16 px above the dialog’s action row (#371) 
    [mobile-chrome] › e2e/public-link-list.spec.ts:157:1 › the “New public link” button keeps 16 px above the dialog’s action row (#371) 


GREEN with the change:
up cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/public-link-list.spec.ts:157:1 › the “New public link” button keeps 16 px above the dialog’s action row (#371) (755ms)
  ✓  2 [mobile-chrome] › e2e/public-link-list.spec.ts:157:1 › the “New public link” button keeps 16 px above the dialog’s action row (#371) (938ms)

  2 passed (4.5s)


## #372
RED without the change:
ils-drawer-la-6c911--without-a-placeholder-372--mobile-chrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/tags-the-details-drawer-la-6c911--without-a-placeholder-372--mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/tags-the-details-drawer-la-6c911--without-a-placeholder-372--mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  2 failed
    [desktop-chrome] › e2e/tags.spec.ts:165:1 › the details drawer labels the tag field visibly, without a placeholder (#372) 
    [mobile-chrome] › e2e/tags.spec.ts:165:1 › the details drawer labels the tag field visibly, without a placeholder (#372) 


GREEN with the change:
 an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  ✓  1 [desktop-chrome] › e2e/tags.spec.ts:165:1 › the details drawer labels the tag field visibly, without a placeholder (#372) (751ms)
  ✓  2 [mobile-chrome] › e2e/tags.spec.ts:165:1 › the details drawer labels the tag field visibly, without a placeholder (#372) (750ms)

  2 passed (4.1s)

🤖 Generated with Claude Code

…e mono face; '

#370 renders the reserve sentence with <i18n-t> and .value-mono slots and fixes the percentage spacing (U+00A0 in de, '5%' in en); #371 adds margin-bottom: var(--space-4) to .link-new; #372 gives the drawer's tag field a visible .fs-label and drops the placeholder. Fixed the #372 E2E flake (403 from reading the CSRF token before the login redirect finished) by waiting for the nav first, as the file's other tests do.

Refs #370 #371 #372

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant