Skip to content

fix(#368): Preview on a phone is a half-height sheet at the bottom instead of filling the s - #377

Merged
BeSovereign merged 1 commit into
mainfrom
fix/issue-368
Oct 19, 2026
Merged

BeSovereign merged 1 commit into
mainfrom
fix/issue-368

Conversation

@BeSovereign

Copy link
Copy Markdown
Contributor

Refs #368

On phone width the wide dialog (preview) now has a fixed height of the viewport minus the scrim margin (web/src/styles/app.css), so a short file's preview fills the screen instead of sitting as a half-height sheet at the bottom. A mobile-chrome Playwright test checks the preview height of a 2-line .txt; DECISIONS.md records that the batch-rename wide dialog follows the same rule.

Driver gates (measured, not claimed)

  • Suites: typecheck: 1 passed, 0 failed | lint: 1 passed, 0 failed | unit: 1167 passed, 0 failed | e2e: 569 passed, 0 failed
  • Red/green check on declared tests: e2e/preview.spec.ts
red/green output
RED without the change:
───────────────────────────────────

    Error Context: test-results/preview-on-a-phone-a-short-8706d-ht-sheet-at-the-bottom-368--mobile-chrome/error-context.md

    attachment #3: trace (application/zip) ─────────────────────────────────────────────────────────
    test-results/preview-on-a-phone-a-short-8706d-ht-sheet-at-the-bottom-368--mobile-chrome/trace.zip
    Usage:

        pnpm exec playwright show-trace test-results/preview-on-a-phone-a-short-8706d-ht-sheet-at-the-bottom-368--mobile-chrome/trace.zip

    ────────────────────────────────────────────────────────────────────────────────────────────────

  1 failed
    [mobile-chrome] › e2e/preview.spec.ts:221:1 › on a phone a short text file still gets a full-height preview, not a half-height sheet at the bottom (#368) 
  1 skipped


GREEN with the change:
e comment. The comment will be removed to avoid issues.

(!) Some chunks are larger than 500 kB after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
$ node build.mjs


Running 2 tests using 1 worker

  -  1 [desktop-chrome] › e2e/preview.spec.ts:221:1 › on a phone a short text file still gets a full-height preview, not a half-height sheet at the bottom (#368)
  ✓  2 [mobile-chrome] › e2e/preview.spec.ts:221:1 › on a phone a short text file still gets a full-height preview, not a half-height sheet at the bottom (#368) (1.3s)

  1 skipped
  1 passed (6.3s)

🤖 Generated with Claude Code

On phone width the wide dialog (preview) now has a fixed height of the viewport minus the scrim margin (web/src/styles/app.css), so a short file's preview fills the screen instead of sitting as a half-height sheet at the bottom. A mobile-chrome Playwright test checks the preview height of a 2-line .txt; DECISIONS.md records that the batch-rename wide dialog follows the same rule.

Refs #368

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@BeSovereign
BeSovereign merged commit 5941a6b into main Oct 19, 2026
3 checks passed
@BeSovereign
BeSovereign deleted the fix/issue-368 branch October 19, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant