Repository navigation
Show company and groups in the contact list - #637
Closed
Darezwebdeveloper wants to merge 1 commit into
Closed
Darezwebdeveloper wants to merge 1 commit into
Darezwebdeveloper wants to merge 1 commit into
Conversation
Adds two settings (off by default) that add a details line under the contact name in the list view: the organization's company and/or the contact's groups (labels). Search also matches group titles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y1eyNkop3UTi9xa1euQ2m7
Contributor
|
Fossify accepts code contributions only for open issues labeled |
There was a problem hiding this comment.
🟡 Changes recommended
Group mutations leave labels and group-title search results stale in Contacts and Favorites because those tabs’ contact data is not refreshed.
1 open issue
What changed in this PR
Adds optional company and group details to contact list rows and extends contact search to match group titles.
Changes:
- Adds two display settings, both off by default, with English and Spanish labels.
- Introduces a details-enabled contact row and formats company/group information.
- Matches group titles in search and restarts the main screen when either display setting changes.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Adds English setting labels. |
| app/src/main/res/values-es/strings.xml | Adds Spanish setting labels. |
| app/src/main/res/layout/item_contact_with_details.xml | Defines the contact row with a details line. |
| app/src/main/res/layout/activity_settings.xml | Adds company and group display switches. |
| app/src/main/kotlin/org/fossify/contacts/helpers/Constants.kt | Defines preference keys. |
| app/src/main/kotlin/org/fossify/contacts/helpers/Config.kt | Stores both settings with disabled defaults. |
| app/src/main/kotlin/org/fossify/contacts/fragments/MyViewPagerFragment.kt | Includes group titles in contact search. |
| app/src/main/kotlin/org/fossify/contacts/adapters/ContactsAdapter.kt | Selects the details layout and binds company/group text. |
| app/src/main/kotlin/org/fossify/contacts/activities/SettingsActivity.kt | Connects the switches to preferences. |
| app/src/main/kotlin/org/fossify/contacts/activities/MainActivity.kt | Restarts the screen when display settings change. |
Review effort: Balanced
Comment on lines
+516
to
+517
| val groupTitles = contact.groups | ||
| .map { it.title.trim() } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two settings (off by default) that add a details line under the contact name in the list view: the organization's company and/or the contact's groups (labels). Search also matches group titles.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01Y1eyNkop3UTi9xa1euQ2m7