chore(security): switch mend check to full repo baseline scan#723
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Whitesource configuration changes the SCA check run ChangesWhitesource configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 639a69c
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed 25a85fe to https://ForgeRock.github.io/ping-javascript-sdk/pr-723/25a85fe4e930084b722c48c03f69cc2b62dcc47d branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/device-client - 0.0 KB (-10.0 KB, -100.0%) ➖ No Changes➖ @forgerock/oidc-client - 35.3 KB 14 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
vatsalparikh
left a comment
There was a problem hiding this comment.
Tested with login framework PR. Mend security check works with baseline. Thank you so much, Gabriel!
Summary
Switches the Mend (WhiteSource) security check from diff mode to baseline mode, so PR checks report the full repo vulnerability inventory instead of only new vulnerabilities introduced by the diff.
Changes
.whitesourcecheckRunSettings.displayMode—"diff"→"baseline". Only this setting changed; severity thresholds and SAST config untouched.Tests
How to test
1. Confirm config change
Check
.whitesourcein this PR —checkRunSettings.displayModeshould read"baseline".2. Verify on a future PR (not this one)
Important: Mend reads
.whitesourcefrom the base branch, not the PR branch. This PR's own Mend check will still run in diff mode ("did not find any new vulnerabilities", "Base branch total remaining vulnerabilities: N") because the base branch config hasn't changed yet. Thebaselinebehavior only takes effect once this PR merges — verify it on the next PR opened afterward: the Mend check should report total vulnerabilities across the whole repo instead of a diff-only summary.Reference: Mend docs — displayMode / Build Settings
Summary by CodeRabbit