Skip to content

chore(security): switch mend check to full repo baseline scan#723

Merged
SteinGabriel merged 1 commit into
mainfrom
update-mend-security-settings
Jul 17, 2026
Merged

chore(security): switch mend check to full repo baseline scan#723
SteinGabriel merged 1 commit into
mainfrom
update-mend-security-settings

Conversation

@SteinGabriel

@SteinGabriel SteinGabriel commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Switches the Mend (WhiteSource) security check from diff mode to baseline mode, so PR checks report the full repo vulnerability inventory instead of only new vulnerabilities introduced by the diff.

Changes

.whitesource

  • checkRunSettings.displayMode"diff""baseline". Only this setting changed; severity thresholds and SAST config untouched.

Tests

  • No automated test surface — this is a scanner config file, not application code.
  • Validated the file is still valid JSON after the edit.

How to test

1. Confirm config change

Check .whitesource in this PR — checkRunSettings.displayMode should read "baseline".

2. Verify on a future PR (not this one)

Important: Mend reads .whitesource from the base branch, not the PR branch. This PR's own Mend check will still run in diff mode ("did not find any new vulnerabilities", "Base branch total remaining vulnerabilities: N") because the base branch config hasn't changed yet. The baseline behavior only takes effect once this PR merges — verify it on the next PR opened afterward: the Mend check should report total vulnerabilities across the whole repo instead of a diff-only summary.

Reference: Mend docs — displayMode / Build Settings

Summary by CodeRabbit

  • Chores
    • Updated scan result presentation to show baseline comparisons instead of only differences.

@changeset-bot

changeset-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 639a69c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3516b1bd-39ab-4676-a4dd-829c655284d3

📥 Commits

Reviewing files that changed from the base of the PR and between 493f264 and 639a69c.

📒 Files selected for processing (1)
  • .whitesource

📝 Walkthrough

Walkthrough

The Whitesource configuration changes the SCA check run displayMode from diff to baseline.

Changes

Whitesource configuration

Layer / File(s) Summary
Update check run display mode
.whitesource
checkRunSettings.displayMode is changed from "diff" to "baseline".

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: switching Mend to baseline scanning.
Description check ✅ Passed The description clearly explains the config change, testing, and rollout behavior, covering the template's required content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-mend-security-settings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 639a69c

Command Status Duration Result
nx run-many -t build --no-agents ✅ Succeeded 4s View ↗
nx affected -t build lint test typecheck e2e-ci ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-14 22:39:23 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jul 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/@forgerock/davinci-client@723

@forgerock/device-client

pnpm add https://pkg.pr.new/@forgerock/device-client@723

@forgerock/journey-client

pnpm add https://pkg.pr.new/@forgerock/journey-client@723

@forgerock/oidc-client

pnpm add https://pkg.pr.new/@forgerock/oidc-client@723

@forgerock/protect

pnpm add https://pkg.pr.new/@forgerock/protect@723

@forgerock/sdk-types

pnpm add https://pkg.pr.new/@forgerock/sdk-types@723

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/@forgerock/sdk-utilities@723

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/@forgerock/iframe-manager@723

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/@forgerock/sdk-logger@723

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/@forgerock/sdk-oidc@723

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/@forgerock/sdk-request-middleware@723

@forgerock/storage

pnpm add https://pkg.pr.new/@forgerock/storage@723

commit: 639a69c

@github-actions

Copy link
Copy Markdown
Contributor

Deployed 25a85fe to https://ForgeRock.github.io/ping-javascript-sdk/pr-723/25a85fe4e930084b722c48c03f69cc2b62dcc47d branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

🔻 @forgerock/device-client - 0.0 KB (-10.0 KB, -100.0%)
🔻 @forgerock/journey-client - 0.0 KB (-92.6 KB, -100.0%)

➖ No Changes

@forgerock/oidc-client - 35.3 KB
@forgerock/sdk-types - 9.1 KB
@forgerock/davinci-client - 54.4 KB
@forgerock/sdk-utilities - 18.6 KB
@forgerock/device-client - 10.0 KB
@forgerock/journey-client - 92.6 KB
@forgerock/protect - 144.6 KB
@forgerock/iframe-manager - 3.2 KB
@forgerock/sdk-logger - 1.6 KB
@forgerock/storage - 1.5 KB
@forgerock/sdk-request-middleware - 4.6 KB
@forgerock/sdk-oidc - 5.7 KB


14 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

@vatsalparikh vatsalparikh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with login framework PR. Mend security check works with baseline. Thank you so much, Gabriel!

@SteinGabriel
SteinGabriel merged commit cc1a536 into main Jul 17, 2026
9 checks passed
@SteinGabriel
SteinGabriel deleted the update-mend-security-settings branch July 17, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants