Skip to content

fix(ci): pin npm bump to v10 to match node 20 engine requirement#592

Open
SteinGabriel wants to merge 1 commit into
developfrom
fix-ci-issues
Open

fix(ci): pin npm bump to v10 to match node 20 engine requirement#592
SteinGabriel wants to merge 1 commit into
developfrom
fix-ci-issues

Conversation

@SteinGabriel

Copy link
Copy Markdown
Contributor

Summary

CI publish workflow started failing on develop after last merge.

.github/actions/setup-publish/action.yml runs npm install -g npm@latest to update npm for provenance
signing, but npm just cut a new major (12.x) requiring Node ^22.22.2 || ^24.15.0 || >=26.0.0. Workflow
pins Node via .node-version (currently 20), so runner has Node 20.20.2 and install fails with
EBADENGINE.

Fix

Pin the npm bump to npm@10 (latest major still compatible with Node 20's engine range), instead of
floating to latest.

Notes / Risks

  • Pinning to a major still allows drift within 10.x patches.
  • If Node bumped to 22+ later, revisit this pin.
  • Node 20 already bundles npm 10.8.2 with provenance support — the manual "Update npm" step may be
    redundant entirely. Left as-is for this fix, worth reconsidering separately.

@changeset-bot

changeset-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b19d213

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the CI label Jul 17, 2026
@nx-cloud

nx-cloud Bot commented Jul 17, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit b19d213

Command Status Duration Result
nx affected -t build lint test docs e2e-ci ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check --verbose ✅ Succeeded 6s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-17 19:13:36 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jul 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/javascript-sdk@592
pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/ping-protect@592
pnpm add https://pkg.pr.new/ForgeRock/forgerock-javascript-sdk/@forgerock/token-vault@592

commit: b19d213

@vatsalparikh vatsalparikh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I remember, npm 10 has issues during publishing or something. I will let Ryan review this. He has had to update npm before to 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants