Skip to content

fix(workflow-executor): carry the collection name on step error logs #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Scra3 merged 1 commit into from
Jul 30, 2026
+3 −8
Merged

fix(workflow-executor): carry the collection name on step error logs #1791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/workflow-executor/src/executors/base-step-executor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,18 +39,12 @@ export default abstract class BaseStepExecutor<TStep extends StepDefinition = St
}

async execute(): Promise<StepExecutionResult> {
const { baseRecordRef } = this.context;

this.context.logger('Debug', 'Step context', {
...this.logCtx,
collection: baseRecordRef.collectionName,
stepInput: this.context.stepDefinition,
});

this.context.logger('Info', 'Step execution started', {
...this.logCtx,
collection: baseRecordRef.collectionName,
});
this.context.logger('Info', 'Step execution started', this.logCtx);

try {
// Idempotency guard — mutating executors override this. Runs before doExecute so a cache
Expand Down Expand Up @@ -391,13 +385,14 @@ export default abstract class BaseStepExecutor<TStep extends StepDefinition = St
}

protected get logCtx() {
const { runId, stepId, stepIndex, stepDefinition } = this.context;
const { runId, stepId, stepIndex, stepDefinition, baseRecordRef } = this.context;

return {
runId,
stepId,
stepIndex,
stepType: stepDefinition.type,
collection: baseRecordRef.collectionName,
...this.getExtraLogContext(),
};
}
Expand Down
Loading