Repository navigation
feat(web): add pasted SBOM/VEX input and 2 MiB cap to scan form (#32) - #56
containarium-ci[bot] wants to merge 1 commit into
Conversation
Co-authored-by: hsinatfootprintai <149764663+hsinatfootprintai@users.noreply.github.com>
hsinatfootprintai
left a comment
There was a problem hiding this comment.
Review (comment only; this account authored the PR)
Verdict: request changes: the web check is red.
Tests run locally: not re-run; CI: go, e2e, proto SUCCESS, web FAILURE. PR MERGEABLE. Small diff: README +5, scan-form.tsx +38, scan-page.test.tsx +34.
Failing test: ScanPage > sends pasted SBOM/VEX text as sbomDocument (web/src/components/scan-page.test.tsx) fails with TestingLibraryElementError: Unable to find role="region" and name "Low confidence". The new test submits a scan and then looks for a result region that never appears, which suggests the mocked response or the form submit path in the test does not produce a report. It is a test (or test setup) problem until shown otherwise: confirm the real form submits pasted text correctly.
Acceptance (from #32's title and the PR): pasted SBOM/VEX input and a 2 MiB cap on the scan form. Code is present; the only test for the pasted-text path is the failing one, so the behavior is unproven. I did not verify the 2 MiB cap has a test.
Docs impact: README +5, covers the new input.
Blocking
- Fix
scan-page.test.tsxso it passes in CI (and keep a test that the pasted text reachessbomDocument). A revise run (@containarium changes <text>) can do this: it fixed the same kind of failure on #47.
Should fix
- Add a test for the 2 MiB cap (reject over the limit with a message).
|
@containarium changes Fix the failing web check only: web/src/components/scan-page.test.tsx 'sends pasted SBOM/VEX text as sbomDocument' fails with 'Unable to find role=region and name Low confidence'. Make the test submit the form and receive its mocked report so the region renders (or assert on what the pasted-text path actually sends), keep the assertion that the pasted text reaches sbomDocument, and add a test that over 2 MiB of pasted text is rejected with a message. Change nothing else. |
|
The agent will revise pull request #56 using that feedback. It starts from the pull request's branch and updates the same pull request when it is done; nothing is merged automatically. Next: reply |
|
@containarium status |
|
Pull request #56 was opened by the agent for #32; this is that issue's latest run. The last run for this issue (run Next: reply |
|
@containarium changes Fix the failing web check only: web/src/components/scan-page.test.tsx 'sends pasted SBOM/VEX text as sbomDocument' fails with 'Unable to find role=region and name Low confidence'. Make the test submit the form and receive its mocked report so the region renders (or assert on what the pasted-text path actually sends), keep the assertion that the pasted text reaches sbomDocument, and add a test that over 2 MiB of pasted text is rejected with a message. Change nothing else. |
|
The agent will revise pull request #56 using that feedback. It starts from the pull request's branch and updates the same pull request when it is done; nothing is merged automatically. Next: reply |
|
No change was proposed for this issue because the agent's run on the box failed. Nothing was pushed. Next: reply — run |
|
@containarium changes Fix the failing web check only: web/src/components/scan-page.test.tsx 'sends pasted SBOM/VEX text as sbomDocument' fails with 'Unable to find role=region and name Low confidence'. Make the test submit the form and receive its mocked report so the region renders (or assert on what the pasted-text path actually sends), keep the assertion that the pasted text reaches sbomDocument, and add a test that over 2 MiB of pasted text is rejected with a message. Change nothing else. |
|
Pull request #56 has already been revised 2 times, which is the most the agent does on one pull request. Next: make the remaining changes by hand, or close it and reply |
|
Closing: the revise budget was used up by runs the platform refused before the agent started (cloud#3665). Re-running #32 from current main. |
For #32:
Web: SBOM/VEX inputs on the scan form (follow-up to S5)Closes #32
The line above closes the issue when this pull request is merged. The reviewer can edit or delete that line before merging.
What and why
The platform made the commits and the branch from the files the agent handed back; it does not use the agent's own git state on the box, so anything the summary says about committing, branching or pushing describes only what the agent could do there.
The agent's summary, quoted:
The agent's decisions, and where it departed from the issue or the design, quoted:
Changes
web/src/components/scan-form.tsx— 169 linesweb/src/components/scan-page.test.tsx— 166 linesREADME.md— 81 lines3 file(s) in all.
Checks
Review this like any other change. The agent ran on the member's own machine from the text of the issue; the platform has not built or tested it. CI results appear on this pull request.
a8c867f87ce82068313df6d60f523ba8d09cbc37, as reported by the agentbuild_toolsnot_runHow this pull request was made
Opened by the platform from a coding agent's run on a member's box (run
e28175f5). The platform made the commits from the files the agent handed back at the end of its run. Nothing is merged automatically.