Render docs nav labels as their authors wrote them - #5621
Open
dimitrieh wants to merge 1 commit into
Open
Conversation
The docs sidebar capitalised every word, which altered 42 of its 117 labels: "Installing a license" read as "Installing A License", "Upgrading the Node-RED version" as "Upgrading The Node-RED Version", and Bosch Rexroth's ctrlX as CtrlX on the two hardware pages named after it. The rule was there to make a section named after its directory look like a word, turning "install" into "Install". Those labels now come from the section's own navTitle, so nothing needs the transform and everything else was collateral. Breadcrumbs carried the same `capitalize`, on the same authored titles, so it goes too. Only the docs sidebar renders `.handbook-nav`: the handbook has its own component with its own markup, and the Eleventy layout that shared the class is no longer used by any page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #5620, which this depends on. GitHub retargets it to
mainonce that merges.The docs sidebar capitalised every word, which altered 42 of its 117 labels.
Installing a licenseread asInstalling A License,Upgrading the Node-RED versionasUpgrading The Node-RED Version, and Bosch Rexroth'sctrlXasCtrlXon the two hardware pages named after it.The rule existed to make a section named after its directory look like a word, turning
installintoInstall. After #5620 those labels come from the section's ownnavTitle, so nothing needs the transform and everything else was collateral damage. Breadcrumbs carried the samecapitalizeon the same authored titles, so that goes too.Only the docs sidebar renders
.handbook-nav: the handbook has its own component and markup, and no page uses the Eleventy layout that shared the class.Verified in the browser at 1280px: computed
text-transformis nownone, and the labels above render as authored.Related Issue(s)
None.
Checklist