Skip to content

2049 multi series chart clear on refresh - #2072

Merged
n-lark merged 7 commits into
FlowFuse:mainfrom
colinl:2049_multi_series_chart_clear_on_refresh
Sep 4, 2026
Merged

2049 multi series chart clear on refresh#2072
n-lark merged 7 commits into
FlowFuse:mainfrom
colinl:2049_multi_series_chart_clear_on_refresh

Conversation

@colinl

@colinl colinl commented Mar 22, 2026

Copy link
Copy Markdown
Contributor

Description

Fix bugs that caused charts, where multiple series data are passed in each message, to be cleared on refresh.

Related Issue(s)

Closes #2049

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@colinl

colinl commented Mar 22, 2026

Copy link
Copy Markdown
Contributor Author

There were two issues

  1. Server side, in ui_chart.js, the filter code that removed old data did not allow for the fact that msg._datapoint could contain an array of series.
  2. Client side, in UIChart.vue, add(msg) did not correctly handle the array of messages passed from onLoad, if each message contained multiple series.

@colinl

colinl commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@n-lark would it be possible for you to review this?

@n-lark
n-lark self-requested a review September 3, 2026 14:31

@n-lark n-lark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @colinl ty for fixing this, just a couple comments.

Comment thread nodes/widgets/ui_chart.js Outdated
Comment thread ui/src/widgets/ui-chart/UIChart.vue Outdated
colinl and others added 2 commits September 4, 2026 11:58
@colinl

colinl commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

OK, all ready for re-review

@n-lark n-lark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@n-lark
n-lark merged commit 961b186 into FlowFuse:main Sep 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When a chart node is sent real time payloads containing multiple series then the chart is cleared on browser refresh

2 participants