fix: Require broker.enabled for Expert central broker default - #992
Merged
andypalmi merged 2 commits intoAug 4, 2026
Conversation
The Team Broker only renders when forge.broker.enabled is true, so the centralBroker default must be gated on both forge.broker.enabled and forge.broker.teamBroker.enabled. Otherwise enabling only the team broker flag emits a centralBroker with no team broker to bridge from.
Set forge.broker.enabled alongside teamBroker.enabled in the render cases, update the guard error message, and add coverage for the default server value and the broker-disabled regression.
hardillb
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #991.
The Team Broker configuration only renders when
forge.broker.enabledistrue(the wholebroker:block inconfigmap.yamlis gated on it). The central broker default added in #991 was gated only onforge.broker.teamBroker.enabled, so enabling just the team broker flag whileforge.broker.enabledwasfalseemitted anexpert.centralBroker.serverwith no team broker to bridge from.This gates the default (and the accompanying guard) on both flags.
Rendered cases (
helm template):broker.enabled=true+teamBroker.enabled=true→centralBroker.server: expert-broker.flowfuse.com:8883broker.enabled=false+teamBroker.enabled=true→ nocentralBrokeremitted (previously emitted incorrectly)broker.enabled=true+teamBroker.enabled=true+ explicitexpert.broker.address/port→ override respectedbroker.enabled=true+teamBroker.enabled=false+ explicitexpert.broker.address→ fails with guidance to enable both flags