Skip to content

Only show top-banner if no left-banner set - #8360

Merged
Yndira-E merged 2 commits into
mainfrom
toggle-top-banner
Sep 2, 2026
Merged

Only show top-banner if no left-banner set#8360
Yndira-E merged 2 commits into
mainfrom
toggle-top-banner

Conversation

@knolleary

Copy link
Copy Markdown
Member

Part of #8196

This updates the account create page to only show the top-banner if:

  • in the popup window context
  • otherwise, hide if left-banner has been configured

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.76%. Comparing base (43afc17) to head (3d3f023).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8360   +/-   ##
=======================================
  Coverage   76.76%   76.76%           
=======================================
  Files         459      459           
  Lines       24687    24687           
  Branches     6566     6566           
=======================================
  Hits        18951    18951           
  Misses       5736     5736           
Flag Coverage Δ
backend 76.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Yndira-E
Yndira-E merged commit 23a4cb6 into main Sep 2, 2026
36 of 38 checks passed
@Yndira-E
Yndira-E deleted the toggle-top-banner branch September 2, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants