Skip to content

feat: allow uppercase characters in trait keys #8403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zaimwa9 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −7
Open

feat: allow uppercase characters in trait keys #8403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions frontend/web/components/modals/CreateTrait.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@ import React, {
} from 'react'
import Highlight from 'components/Highlight'
import Constants from 'common/constants'
import Format from 'common/utils/format'
import ErrorMessage from 'components/ErrorMessage'
import ModalHR from './ModalHR'
import IdentityProvider from 'common/providers/IdentityProvider'
import find from 'lodash/find'
import ProjectProvider from 'common/providers/ProjectProvider'
import Button from 'components/base/forms/Button'
Expand Down Expand Up @@ -122,11 +120,7 @@ const CreateTrait: FC<CreateTraitProps> = ({
}}
value={traitKey}
onChange={(e: ChangeEvent<HTMLInputElement>) =>
setTraitKey(
Format.enumeration
.set(Utils.safeParseEventValue(e))
.toLowerCase(),
)
setTraitKey(Utils.safeParseEventValue(e).replace(/ /g, '_'))
}
isValid={!!traitKey && traitKey.length > 0}
type='text'
Expand Down
Loading