Skip to content

Remove CompletionHandlerIntegrationTest - #721

Merged
Firehed merged 3 commits into
mainfrom
completion-parse-once-server
Oct 7, 2026
Merged

Firehed merged 3 commits into
mainfrom
completion-parse-once-server

Conversation

@Firehed

@Firehed Firehed commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Deletes CompletionHandlerIntegrationTest, the last of its groups. Part of #694.

Parse once. testCompletionParsesTheDocumentOnce checked one parse per completion request at three positions. With memoization disabled, only the variable-prefix case failed; the member- and static-access positions parse once whether or not the memo works. ServerTest::testParsesAreScopedToOneMessageOnTheRequestPath already sends two variable-prefix completions through Server::forProject and asserts three parses for the open and both requests; its docblock now says why that position was chosen. MemoizingSyntaxSourceTest owns the memo itself.

Wrapped implements. The skipped test pointed at #310, which is closed as not planned; it ran nothing. #720 now tracks the bug with its reproduction and the current output, so the test and its fixture WrappedImplementsCompletion.php go.

🤖 Generated with Claude Code

Firehed and others added 2 commits October 7, 2026 13:36
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.75%. Comparing base (1d343e1) to head (f15b7ad).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #721   +/-   ##
=========================================
  Coverage     82.75%   82.75%           
  Complexity     1901     1901           
=========================================
  Files           135      135           
  Lines          4876     4876           
=========================================
  Hits           4035     4035           
  Misses          841      841           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Firehed
Firehed marked this pull request as ready for review October 7, 2026 20:43
@Firehed
Firehed merged commit 4822e4d into main Oct 7, 2026
9 checks passed
@Firehed
Firehed deleted the completion-parse-once-server branch October 7, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant