Repository navigation
Remove CompletionHandlerIntegrationTest - #721
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
=========================================
Coverage 82.75% 82.75%
Complexity 1901 1901
=========================================
Files 135 135
Lines 4876 4876
=========================================
Hits 4035 4035
Misses 841 841 ☔ View full report in Codecov by Harness. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletes
CompletionHandlerIntegrationTest, the last of its groups. Part of #694.Parse once.
testCompletionParsesTheDocumentOncechecked one parse per completion request at three positions. With memoization disabled, only the variable-prefix case failed; the member- and static-access positions parse once whether or not the memo works.ServerTest::testParsesAreScopedToOneMessageOnTheRequestPathalready sends two variable-prefix completions throughServer::forProjectand asserts three parses for the open and both requests; its docblock now says why that position was chosen.MemoizingSyntaxSourceTestowns the memo itself.Wrapped
implements. The skipped test pointed at #310, which is closed as not planned; it ran nothing. #720 now tracks the bug with its reproduction and the current output, so the test and its fixtureWrappedImplementsCompletion.phpgo.🤖 Generated with Claude Code